* Re: patch for Checkpatch.pl
[not found] <BANLkTikYRvHb0ffdpdzpiTh7S+Ayxw1wew@mail.gmail.com>
@ 2011-05-19 3:58 ` Greg KH
[not found] ` <BANLkTimNqAwy8S9EF2KMU_af4Q+RoXsuqA@mail.gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: Greg KH @ 2011-05-19 3:58 UTC (permalink / raw)
To: anish singh; +Cc: linux-kernel-mail
On Thu, May 19, 2011 at 08:39:57AM +0530, anish singh wrote:
> I am thinking of submitting a patch for checkpatch.pl.
>
> Ideally it should give a warning when there is no space between
> patch submitter name and the email id as below:
> Signed-off-by: anish kumar<anish@gmail.com>
>
> It should be as below:
> Signed-off-by: anish kumar <anish@gmail.com>
>
> Please let me know if it is fine.I will send it right away as i have
> it ready.
As you are the only one I have ever seen do this before, I doubt it's
really needed for the checkpatch script, right?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: patch for Checkpatch.pl
[not found] ` <BANLkTimNqAwy8S9EF2KMU_af4Q+RoXsuqA@mail.gmail.com>
@ 2011-05-19 4:30 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-05-19 4:30 UTC (permalink / raw)
To: anish singh; +Cc: linux-kernel-mail
On Thu, May 19, 2011 at 09:33:08AM +0530, anish singh wrote:
>
>
> On Thu, May 19, 2011 at 9:28 AM, Greg KH <greg@kroah.com> wrote:
>
> On Thu, May 19, 2011 at 08:39:57AM +0530, anish singh wrote:
> > I am thinking of submitting a patch for checkpatch.pl.
> >
> > Ideally it should give a warning when there is no space between
> > patch submitter name and the email id as below:
> > Signed-off-by: anish kumar<anish@gmail.com>
> >
> > It should be as below:
> > Signed-off-by: anish kumar <anish@gmail.com>
> >
> > Please let me know if it is fine.I will send it right away as i have
> > it ready.
>
> As you are the only one I have ever seen do this before, I doubt it's
> really needed for the checkpatch script, right?
>
> Yes my bad but when we don't add space after Signed-off-by:_
> it says that space is required.So thought this is also required.
> Anyway if it is not needed i am ok.
If it's a simple patch, that's fine, send it in.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-19 4:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <BANLkTikYRvHb0ffdpdzpiTh7S+Ayxw1wew@mail.gmail.com>
2011-05-19 3:58 ` patch for Checkpatch.pl Greg KH
[not found] ` <BANLkTimNqAwy8S9EF2KMU_af4Q+RoXsuqA@mail.gmail.com>
2011-05-19 4:30 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox