From: Greg KH <greg@kroah.com>
To: anish singh <anish198519851985@gmail.com>
Cc: linux-kernel-mail <linux-kernel@vger.kernel.org>
Subject: Re: patch for Checkpatch.pl
Date: Wed, 18 May 2011 21:30:53 -0700 [thread overview]
Message-ID: <20110519043053.GA10187@kroah.com> (raw)
In-Reply-To: <BANLkTimNqAwy8S9EF2KMU_af4Q+RoXsuqA@mail.gmail.com>
On Thu, May 19, 2011 at 09:33:08AM +0530, anish singh wrote:
>
>
> On Thu, May 19, 2011 at 9:28 AM, Greg KH <greg@kroah.com> wrote:
>
> On Thu, May 19, 2011 at 08:39:57AM +0530, anish singh wrote:
> > I am thinking of submitting a patch for checkpatch.pl.
> >
> > Ideally it should give a warning when there is no space between
> > patch submitter name and the email id as below:
> > Signed-off-by: anish kumar<anish@gmail.com>
> >
> > It should be as below:
> > Signed-off-by: anish kumar <anish@gmail.com>
> >
> > Please let me know if it is fine.I will send it right away as i have
> > it ready.
>
> As you are the only one I have ever seen do this before, I doubt it's
> really needed for the checkpatch script, right?
>
> Yes my bad but when we don't add space after Signed-off-by:_
> it says that space is required.So thought this is also required.
> Anyway if it is not needed i am ok.
If it's a simple patch, that's fine, send it in.
prev parent reply other threads:[~2011-05-19 4:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTikYRvHb0ffdpdzpiTh7S+Ayxw1wew@mail.gmail.com>
2011-05-19 3:58 ` patch for Checkpatch.pl Greg KH
[not found] ` <BANLkTimNqAwy8S9EF2KMU_af4Q+RoXsuqA@mail.gmail.com>
2011-05-19 4:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519043053.GA10187@kroah.com \
--to=greg@kroah.com \
--cc=anish198519851985@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox