From: Ralf Baechle <ralf@linux-mips.org>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: dediao@cisco.com, ddaney@caviumnetworks.com, dvomlehn@cisco.com,
sshtylyov@mvista.com, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] MIPS: HIGHMEM DMA on noncoherent MIPS32 processors
Date: Thu, 19 May 2011 12:06:38 +0100 [thread overview]
Message-ID: <20110519110638.GA11371@linux-mips.org> (raw)
In-Reply-To: <002fbbeb01a5a51fff8015af85d5d101@localhost>
On Wed, Oct 13, 2010 at 04:57:35PM -0700, Kevin Cernekee wrote:
> [v4: Patch applies to linux-queue.git with kmap_atomic patches:
> https://patchwork.kernel.org/patch/189932/
> https://patchwork.kernel.org/patch/194552/
> https://patchwork.kernel.org/patch/189912/ ]
>
> The MIPS DMA coherency functions do not work properly (i.e. kernel oops)
> when HIGHMEM pages are passed in as arguments. Use kmap_atomic() to
> temporarily map high pages for cache maintenance operations.
>
> Tested on a 2.6.36-rc7 1GB HIGHMEM SMP no-alias system.
And I don't think it's going to work on an alias system. __dma_sync maps
a page but it doesn't know the previous mapping (or could there be any
other mappings at the same time?). That's going to fail with aliases.
Not that this was previously working so I don't blame you for it.
Who is the author of this patch, you or Dezhong Diao?
Ralf
next prev parent reply other threads:[~2011-05-19 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 23:57 [PATCH v4] MIPS: HIGHMEM DMA on noncoherent MIPS32 processors Kevin Cernekee
2011-05-19 11:06 ` Ralf Baechle [this message]
2011-05-19 15:05 ` Kevin Cernekee
2011-05-19 15:15 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519110638.GA11371@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=cernekee@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=dediao@cisco.com \
--cc=dvomlehn@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox