Re: [RFC PATCH] perf: Split up buffer handling from core code

Frederic Weisbecker
2011-05-19T15:15:37Z

On Thu, May 19, 2011 at 05:14:01PM +0200, Peter Zijlstra wrote:
> On Thu, 2011-05-19 at 16:59 +0200, Frederic Weisbecker wrote:
> > I thought it would be nice to keep it inline for core use, as it's called
> > pretty often from the overflow path.
>
> That's what I meant.
>
> > A solution is to have a perf_output_copy_inline() in internal.h
> > and export it through perf_output_copy() in buffer.c
>
> If only "external inline" would work :-)

Hehe :)

> I'd call it __perf_output_copy() though, less typing.

Fine!