Re: [PATCH] perf: Split up buffer handling from core code

Ingo Molnar
2011-06-01T07:06:25Z

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> On Thu, May 19, 2011 at 07:55:04PM +0200, Frederic Weisbecker wrote:
> > And create the internal perf events header.
> >
> > v2: Keep an internal inlined perf_output_copy()
> >
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Stephane Eranian <eranian@google.com>
> > ---
>
> Are you guys fine with his patch?
> If so, should I queue it myself and send a pull request?

Yeah, please do it ASAP.

> I prefer to work step by step on this split, to avoid too much
> review burden. And also a single detail can require to rework the
> whole.

Please lets just start it so that the interactions get smaller!

core.c couldnt be uglier as it is today, so after a first raw split
we can sort out any fine details - just make sure you don't break the
build.

Thanks,

Ingo