RE: [PATCH] x86: Removing unnecessary check in detect_ht

Rao, Nikhil
2011-05-19T02:40:08Z

Hi Ingo,

Reposting as per your feedback.

Thanks,
Nikhil

---
This patch removes a check that causes incorrect scheduler domain
setup (SMP instead of SMT) and bootlog warning messages when cpuid
extensions for topology enumeration are not supported and the number
of processors reported to the OS is smaller than smp_num_siblings

Signed-off-by: Nikhil P Rao <nikhil.rao@intel.com>
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
---
arch/x86/kernel/cpu/common.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index e2ced007..6547084 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -458,13 +458,6 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c)
if (smp_num_siblings <= 1)
goto out;

- if (smp_num_siblings > nr_cpu_ids) {
- pr_warning("CPU: Unsupported number of siblings %d",
- smp_num_siblings);
- smp_num_siblings = 1;
- return;
- }
-
index_msb = get_count_order(smp_num_siblings);
c->phys_proc_id = apic->phys_pkg_id(c->initial_apicid, index_msb);

--
1.7.4.2

> -----Original Message-----
> From: Ingo Molnar [mailto:mingo@elte.hu]
> Sent: Wednesday, May 18, 2011 2:24 PM
> To: Rao, Nikhil
> Cc: tglx@linutronix.de; mingo@redhat.com; hpa@zytor.com;
> x86@kernel.org; Siddha, Suresh B; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] x86: Removing unnecessary check in detect_ht
>
>
> * Rao, Nikhil <nikhil.rao@intel.com> wrote:
>
> > Nothing apart from what you mention - bootlog message and SMP instead
> of SMT.
>
> Mind putting this information into the changelog and repost the patch?
> It's
> arguably the kind of practical information that most readers of
> changelogs are
> interested in.
>
> Thanks,
>
> Ingo