RE: [PATCH] x86: Removing unnecessary check in detect_ht

Rao, Nikhil
2011-05-18T21:13:23Z

Nothing apart from what you mention - bootlog message and SMP instead of SMT.

Nikhil

> -----Original Message-----
> From: Ingo Molnar [mailto:mingo@elte.hu]
> Sent: Wednesday, May 18, 2011 2:08 PM
> To: Rao, Nikhil
> Cc: tglx@linutronix.de; mingo@redhat.com; hpa@zytor.com;
> x86@kernel.org; Siddha, Suresh B; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] x86: Removing unnecessary check in detect_ht
>
>
> * Rao, Nikhil <nikhil.rao@intel.com> wrote:
>
> > This patch removes a check that prevents correct CPU topology setup
> > when cpuid extensions for topology enumeration are not supported and
> > the number of processors reported to the OS is smaller than
> > smp_num_siblings
>
> What bad effect was observed, exactly? An annoying warning in the
> bootlog and
> incorrect scheduler domain setup (SMP instead of SMT) - or something
> else as
> well?
>
> Thanks,
>
> Ingo