Re: [PATCH] x86: Removing unnecessary check in detect_ht

Nikhil P Rao
2011-05-25T17:18:55Z

This patch removes a check that causes incorrect scheduler domain
setup (SMP instead of SMT) and bootlog warning messages when cpuid
extensions for topology enumeration are not supported and the number
of processors reported to the OS is smaller than smp_num_siblings

Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Nikhil P Rao <nikhil.rao@intel.com>
---
arch/x86/kernel/cpu/common.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index cbc70a2..d2bcd54 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -477,13 +477,6 @@ void __cpuinit detect_ht(struct cpuinfo_x86 *c)
if (smp_num_siblings <= 1)
goto out;

- if (smp_num_siblings > nr_cpu_ids) {
- pr_warning("CPU: Unsupported number of siblings %d",
- smp_num_siblings);
- smp_num_siblings = 1;
- return;
- }
-
index_msb = get_count_order(smp_num_siblings);
c->phys_proc_id = apic->phys_pkg_id(c->initial_apicid, index_msb);

--
1.7.4.4

On Fri, 2011-05-20 at 13:46 +0200, Ingo Molnar wrote:

> Your patch does not apply because it's whitespace damaged (all tabs got
> converted to spaces). Please see Documentation/email-clients.txt.
>
> Thanks,
>
> Ingo