From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934701Ab1ESUdU (ORCPT ); Thu, 19 May 2011 16:33:20 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:39833 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932164Ab1ESUdS (ORCPT ); Thu, 19 May 2011 16:33:18 -0400 Date: Thu, 19 May 2011 21:33:08 +0100 From: Matthew Garrett To: Yinghai Lu Cc: linux-kernel@vger.kernel.org, x86@vkernel.org, hpa@zytor.com, Benjamin Herrenschmidt , Ingo Molnar Subject: Re: [PATCH] efi: Retain boot service code until after switching to virtual mode Message-ID: <20110519203308.GA2106@srcf.ucam.org> References: <1305826343-3302-1-git-send-email-mjg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2011 at 01:26:27PM -0700, Yinghai Lu wrote: > how many entries are listed in memmap? So far I've been seeing about 20 boot services entries at most. > Did you test this system that have lots of those entries ? like > 128? Do any exist? > because efi_init() is called before memblock_x86_fill(), that means > memblock array for reserved can not be doubled yet. --- no usable > entries in memblock array for ram. Mm. I guess this can be shifted later. > > +        * get rid of it all at this point > > +        */ > > +       free_efi_boot_services(); > > + > > No, at that point memblock is not used any more. after mm_init()/mem_init() > > need to use free_bootmem_late() in free_efi_boot_services Ah, ok. -- Matthew Garrett | mjg59@srcf.ucam.org