From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd wm8350: allocate irq descs dynamically
Date: Thu, 19 May 2011 14:04:41 -0700 [thread overview]
Message-ID: <20110519210440.GA18849@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110519185648.GR30963@pengutronix.de>
On Thu, May 19, 2011 at 08:56:48PM +0200, Sascha Hauer wrote:
> - if (!pdata || !pdata->irq_base) {
> - dev_warn(wm8350->dev, "No interrupt support, no IRQ base\n");
> + if (!pdata) {
> + dev_warn(wm8350->dev, "No interrupt support, no platform data\n");
This isn't terribly good, the only reason we're checking pdata here is
because we can't dereference it to look up irq_base if it's not there.
next prev parent reply other threads:[~2011-05-19 21:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 18:56 [PATCH] mfd wm8350: allocate irq descs dynamically Sascha Hauer
2011-05-19 21:04 ` Mark Brown [this message]
2011-05-19 22:04 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2011-06-02 11:45 Sascha Hauer
2011-06-02 11:53 ` Mark Brown
2011-06-02 13:37 ` Mark Brown
2011-06-02 15:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519210440.GA18849@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox