From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, arnd@arndb.de, mmarek@suse.cz,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kstrtox: drop kstrtol()/kstrtoul() when possible
Date: Thu, 19 May 2011 23:54:49 -0700 [thread overview]
Message-ID: <20110519235449.ac0ac1c4.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110520064827.GA14185@p183>
On Fri, 20 May 2011 09:48:27 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Fri, May 20, 2011 at 08:20:42AM +0200, Geert Uytterhoeven wrote:
> > On Fri, May 20, 2011 at 08:15, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > > If "long" and "long long" types are identical at runtime,
> > > kstrtol() can be aliased to kstrtoll().
> > >
> > > Unfortunately, one can't write
> > >
> > > __ __ __ __#if sizeof(long) == sizeof(long long) ...
> >
> > One can write #ifdef CONFIG_64BIT instead.
>
> And alignment will match, on any arch, now and in future?
> I don't think so.
Don't worry about it.
z:/usr/src/linux-2.6.39> grep -r "#[ ]*if.*CONFIG_64BIT" . | wc -l
547
So much other stuff will break that kstrtofoo is a drop in the bucket.
next prev parent reply other threads:[~2011-05-20 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 6:15 [PATCH] kstrtox: drop kstrtol()/kstrtoul() when possible Alexey Dobriyan
2011-05-20 6:20 ` Geert Uytterhoeven
2011-05-20 6:48 ` Alexey Dobriyan
2011-05-20 6:54 ` Andrew Morton [this message]
2011-05-20 7:21 ` Alexey Dobriyan
2011-05-20 7:54 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519235449.ac0ac1c4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox