From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH v2] regulator: Fix _regulator_get_voltage if get_voltage callback is NULL
Date: Fri, 20 May 2011 11:23:02 +0100 [thread overview]
Message-ID: <20110520102302.GD22711@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1305851766.2244.2.camel@phoenix>
On Fri, May 20, 2011 at 08:36:06AM +0800, Axel Lin wrote:
> - return ret - rdev->constraints->uV_offset;
> + return ret < 0 ? ret : ret - rdev->constraints->uV_offset;
Please don't use the ternery operator, I find it does nothing for
legibility.
prev parent reply other threads:[~2011-05-20 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 0:36 [PATCH v2] regulator: Fix _regulator_get_voltage if get_voltage callback is NULL Axel Lin
2011-05-20 10:23 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110520102302.GD22711@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox