From: Andy Whitcroft <apw@canonical.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: NeilBrown <neilb@suse.de>,
viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
nbd@openwrt.org, hramrach@centrum.cz, jordipujolp@gmail.com
Subject: Re: [PATCH 0/7] overlay filesystem v9
Date: Fri, 20 May 2011 13:43:39 +0100 [thread overview]
Message-ID: <20110520124339.GS3702@shadowen.org> (raw)
In-Reply-To: <87ipt5vl7t.fsf@tucsk.pomaz.szeredi.hu>
On Fri, May 20, 2011 at 10:18:30AM +0200, Miklos Szeredi wrote:
> Yeah, it should probably do something like:
>
> if (inode->i_op->getattr) {
> struct kstat stat;
> inode->i_op->getattr(...)
> uid = stat.uid;
> } else {
> uid = inode->i_uid;
> }
>
> The problem is that getattr takes a vfsmount, which makes this
> impossible to do cleanly. And the solution is for ->getattr() to lose
> that argument, which is a bit more involved :(
Ok. I am going to take this as a bug in the LSM, so ignore my patch
here. I have been poking at what the LSM is doing and actually I think
I see the flaw, so I will take the issue up with them.
In light of that take this as a "tested heavily and it worked without
issues" on the V9 version.
Tested-by: Andy Whitcroft <apw@canonical.com>
-apw
next prev parent reply other threads:[~2011-05-20 12:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 12:30 [PATCH 0/7] overlay filesystem v9 Miklos Szeredi
2011-05-17 12:30 ` [PATCH 1/7] tmpfs: implement generic xattr support Miklos Szeredi
2011-05-17 12:30 ` [PATCH 2/7] vfs: add i_op->open() Miklos Szeredi
2011-05-17 12:30 ` [PATCH 3/7] vfs: export do_splice_direct() to modules Miklos Szeredi
2011-05-17 12:30 ` [PATCH 4/7] vfs: introduce clone_private_mount() Miklos Szeredi
2011-05-17 12:30 ` [PATCH 5/7] overlay filesystem Miklos Szeredi
2011-05-17 12:30 ` [PATCH 6/7] overlayfs: add statfs support Miklos Szeredi
2011-05-17 12:30 ` [PATCH 7/7] overlay: overlay filesystem documentation Miklos Szeredi
2011-05-17 15:13 ` [PATCH 0/7] overlay filesystem v9 Michal Suchanek
2011-05-19 16:37 ` Andy Whitcroft
2011-05-19 17:44 ` Miklos Szeredi
2011-05-19 18:05 ` Andy Whitcroft
2011-05-19 22:12 ` NeilBrown
2011-05-20 8:18 ` Miklos Szeredi
2011-05-20 12:43 ` Andy Whitcroft [this message]
2011-05-19 19:04 ` John Stoffel
2011-05-19 20:30 ` Andy Whitcroft
2011-05-19 20:34 ` John Stoffel
2011-05-19 18:04 ` Andy Whitcroft
2011-05-20 8:56 ` Michal Suchanek
[not found] ` <103d3f78e2d3478d8bb93f5dda3a4a08@HUBCAS1.cs.stonybrook.edu>
2011-05-20 5:39 ` [PATCH 5/7] overlay filesystem (inode.c bad error path) Erez Zadok
2011-05-20 5:55 ` Erez Zadok
2011-05-20 14:25 ` Miklos Szeredi
[not found] ` <efad20cd4c664cd78e153b0fda2de605@HUBCAS2.cs.stonybrook.edu>
2011-05-21 5:15 ` Erez Zadok
2011-05-20 8:54 ` Miklos Szeredi
2011-05-20 14:17 ` Miklos Szeredi
[not found] ` <7dcd9c4e62864bc6aae66f5a4e3f3752@HUBCAS1.cs.stonybrook.edu>
2011-05-21 4:26 ` Erez Zadok
2011-05-23 8:57 ` Miklos Szeredi
[not found] ` <b11ac28b818740a8b3f619e756735e41@HUBCAS2.cs.stonybrook.edu>
2011-05-24 1:02 ` Erez Zadok
2011-05-20 5:58 ` [PATCH 5/7] overlay filesystem (negative dentries cause OOPS on NULL inode) Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110520124339.GS3702@shadowen.org \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=hramrach@centrum.cz \
--cc=jordipujolp@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=nbd@openwrt.org \
--cc=neilb@suse.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).