linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bq27x00_battery: Name of cycle count property
@ 2011-04-30 21:59 Pali Rohár
  2011-05-20 15:51 ` Anton Vorontsov
  0 siblings, 1 reply; 2+ messages in thread
From: Pali Rohár @ 2011-04-30 21:59 UTC (permalink / raw)
  To: Anton Vorontsov, Grazvydas Ignotas, Lars-Peter Clausen,
	Rodolfo Giometti, LKML

This patch fix using correct property POWER_SUPPLY_PROP_CYCLE_COUNT
for cycle count instead POWER_SUPPLY_PROP_CHARGE_COUNTER

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Pali Rohár <pali.rohar@gmail.com>

--- a/drivers/power/bq27x00_battery.c	2011-02-27 12:14:56.000000000 +0100
+++ b/drivers/power/bq27x00_battery.c	2011-04-30 23:50:19.000000000 +0200
@@ -4,6 +4,7 @@
  * Copyright (C) 2008 Rodolfo Giometti <giometti@linux.it>
  * Copyright (C) 2008 Eurotech S.p.A. <info@eurotech.it>
  * Copyright (C) 2010-2011 Lars-Peter Clausen <lars@metafoo.de>
+ * Copyright (C) 2011 Pali Rohár <pali.rohar@gmail.com>
  *
  * Based on a previous work by Copyright (C) 2008 Texas Instruments, Inc.
  *
@@ -76,7 +77,7 @@ struct bq27x00_reg_cache {
 	int time_to_empty_avg;
 	int time_to_full;
 	int charge_full;
-	int charge_counter;
+	int cycle_count;
 	int capacity;
 	int flags;

@@ -115,7 +116,7 @@ static enum power_supply_property bq27x0
 	POWER_SUPPLY_PROP_CHARGE_FULL,
 	POWER_SUPPLY_PROP_CHARGE_NOW,
 	POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
-	POWER_SUPPLY_PROP_CHARGE_COUNTER,
+	POWER_SUPPLY_PROP_CYCLE_COUNT,
 	POWER_SUPPLY_PROP_ENERGY_NOW,
 };

@@ -267,7 +268,7 @@ static void bq27x00_update(struct bq27x0
 		cache.time_to_empty_avg = bq27x00_battery_read_time(di, BQ27x00_REG_TTECP);
 		cache.time_to_full = bq27x00_battery_read_time(di, BQ27x00_REG_TTF);
 		cache.charge_full = bq27x00_battery_read_lmd(di);
-		cache.charge_counter = bq27x00_battery_read_cyct(di);
+		cache.cycle_count = bq27x00_battery_read_cyct(di);

 		if (!is_bq27500)
 			cache.current_now = bq27x00_read(di, BQ27x00_REG_AI, false);
@@ -496,8 +497,8 @@ static int bq27x00_battery_get_property(
 	case POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN:
 		ret = bq27x00_simple_value(di->charge_design_full, val);
 		break;
-	case POWER_SUPPLY_PROP_CHARGE_COUNTER:
-		ret = bq27x00_simple_value(di->cache.charge_counter, val);
+	case POWER_SUPPLY_PROP_CYCLE_COUNT:
+		ret = bq27x00_simple_value(di->cache.cycle_count, val);
 		break;
 	case POWER_SUPPLY_PROP_ENERGY_NOW:
 		ret = bq27x00_battery_energy(di, val);


-- 
Pali Rohár
pali.rohar@gmail.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] bq27x00_battery: Name of cycle count property
  2011-04-30 21:59 [PATCH] bq27x00_battery: Name of cycle count property Pali Rohár
@ 2011-05-20 15:51 ` Anton Vorontsov
  0 siblings, 0 replies; 2+ messages in thread
From: Anton Vorontsov @ 2011-05-20 15:51 UTC (permalink / raw)
  To: Pali Rohár
  Cc: Grazvydas Ignotas, Lars-Peter Clausen, Rodolfo Giometti, LKML

On Sat, Apr 30, 2011 at 11:59:35PM +0200, Pali Rohár wrote:
> This patch fix using correct property POWER_SUPPLY_PROP_CYCLE_COUNT
> for cycle count instead POWER_SUPPLY_PROP_CHARGE_COUNTER
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> Tested-by: Pali Rohár <pali.rohar@gmail.com>

Pali, thanks a lot!

This is now applied.

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-20 15:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-30 21:59 [PATCH] bq27x00_battery: Name of cycle count property Pali Rohár
2011-05-20 15:51 ` Anton Vorontsov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).