From: Dmitry Artamonow <mad_soft@inbox.ru>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Paul Parsons <lost.distance@yahoo.com>,
linux-kernel@vger.kernel.org, dwmw2@infradead.org,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH] ds2760_battery: Fix rated capacity of the hx4700 1800mAh battery
Date: Fri, 20 May 2011 21:45:46 +0400 [thread overview]
Message-ID: <20110520174546.GA27734@rainbow> (raw)
In-Reply-To: <20110520154724.GB18099@oksana.dev.rtsoft.ru>
On 19:47 Fri 20 May , Anton Vorontsov wrote:
> On Mon, Apr 25, 2011 at 01:45:40PM +0000, Paul Parsons wrote:
[snip]
> > --- clean-2.6.39-rc4/drivers/power/ds2760_battery.c 2011-03-15 01:20:32.000000000 +0000
> > +++ linux-2.6.39-rc4/drivers/power/ds2760_battery.c 2011-04-25 13:06:29.344976841 +0100
> > @@ -86,7 +86,11 @@ static int rated_capacities[] = {
> > 920, /* NEC */
> > 1440, /* Samsung */
> > 1440, /* BYD */
> > +#ifdef CONFIG_MACH_H4700
> > + 1800, /* HP iPAQ hx4700 3.7V 1800mAh (359113-001) */
> > +#else
> > 1440, /* Lishen */
> > +#endif
> > 1440, /* NEC */
>
> Note that this is OK as a temporary fix, but in general such fixups
> should be done via platform data. So, it would be great if you could
> prepare another patch on top of this one, which would do things in
> a proper way.
BTW, hx4700 also have extended batteries. I personally have one that rated
3600mAh with my hx4700. Sadly I dropped it on the floor some time ago and
battery lock got broken, so I currently can't use it. But I hope to fix it
some day.
It looks like this one, but made by PALMEXX (Part No.359113-001):
http://www.amazon.com/Li-Ion-359113-001-Battery-hx4700-hx4705/dp/B000VN7QMQ
--
Best regards,
Dmitry "MAD" Artamonow
next prev parent reply other threads:[~2011-05-20 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 13:45 [PATCH] ds2760_battery: Fix rated capacity of the hx4700 1800mAh battery Paul Parsons
2011-05-20 15:47 ` Anton Vorontsov
2011-05-20 17:45 ` Dmitry Artamonow [this message]
2011-05-20 18:34 ` Paul Parsons
2011-05-20 19:14 ` Dmitry Artamonow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110520174546.GA27734@rainbow \
--to=mad_soft@inbox.ru \
--cc=cbouatmailru@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox