Re: [tip:tools/kvm] kvm tools: Add conditional compilation of symbol resolving

[Ingo Molnar <mingo@elte.hu>]

* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * tip-bot for Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> 
> > diff --git a/tools/perf/feature-tests.mak b/tools/kvm/config/feature-tests.mak
> > similarity index 83%
> > copy from tools/perf/feature-tests.mak
> > copy to tools/kvm/config/feature-tests.mak
> 
> Btw, now that we have feature-tests.mak it would be nice to populate the checks 
> for the various assumptions.
> 
> One i recently ran into on a new box where i tried to install tools/kvm was:
> 
> In file included from /usr/include/features.h:387:0,
>                  from /usr/include/unistd.h:26,
>                  from include/kvm/util.h:12,
>                  from bios/e820.c:5:
> /usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory
> compilation terminated.
> make: *** [bios/bios-rom.bin] Error 1
> 
> that's a dependency on glibc-dev[el].

Another detail: on 64-bit hosts the dependency is on gibc-dev[el].i686, i.e. 
the 32-bit package.

Would it be simple to remove this dependency? It's not typically installed by 
default on distros and it would be nice to make most of the kvm code build by 
default almost everywhere.

Thanks,

	Ingo