Re: [PATCHv2 5/5] TPS65911: Comparator: Add comparator driver

[Samuel Ortiz <sameo@linux.intel.com>]

On Sat, May 14, 2011 at 03:29:45PM -0700, Mark Brown wrote:
> On Fri, May 13, 2011 at 06:59:32PM +0200, Samuel Ortiz wrote:
> > On Wed, May 04, 2011 at 07:21:46PM -0500, Jorge Eduardo Candelaria wrote:
> 
> > > +config TPS65911_COMPARATOR
> > > +	tristate "TPS65911 Comparator"
> > > +	depends on MFD_TPS65910
> > > +	help
> > > +	  if you say yes here you get support for the TPS65910 comparator
> > > +	  module.
> 
> > I still don't know what it compares and why I would want to enable that.
> 
> It'll be comparing two voltages - it's quite a common feature for PMICs
> with auxadcs.  I think I said in one of my previous reviews that it
> probably shouldn't be user visible in Kconfig as some other driver will
> need to be written to call it so that driver could just select the
> symbol.
> 
> > This driver really looks like it could belong to drivers/regulator.
> 
> It's measuring rather than producing.
Sure, but I still don't see how it belongs to drivers/mfd/.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/