Re: [GIT PULL] perf tools fixes

Ingo Molnar
2011-05-23T11:18:44Z

* Ingo Molnar <mingo@elte.hu> wrote:

>
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
>
> > Ingo,
> >
> > Please pull the perf/urgent branch that can be found at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
> > perf/urgent
> >
> > Thanks,
> > Frederic
> > ---
> >
> > Frederic Weisbecker (2):
> > perf tools: Fix sample size bit operations
> > perf tools: Fix ommitted mmap data update on remap
> >
> >
> > tools/perf/util/event.c | 2 +-
> > tools/perf/util/session.c | 39 ++++++++++++++++++++++++++-------------
> > 2 files changed, 27 insertions(+), 14 deletions(-)

Hm, you broke perf top:

PerfTop: 0 irqs/sec kernel:-nan% exact: -nan% [1000Hz cycles], (all, 16 CPUs)
-------------------------------------------------------------------------------------------------------

samples pcnt DSO
_______ _____

Can't parse sample, err = -14
Can't parse sample, err = -14
Can't parse sample, err = -14
Can't parse sample, err = -14
Can't parse sample, err = -14
Can't parse sample, err = -14

and perf record+report as well:

aldebaran:~/linux/linux> perf record -a sleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.119 MB perf.data (~5201 samples) ]
aldebaran:~/linux/linux> perf report --stdio
The perf.data file has no samples!

so i'm unpulling these bits.

Thanks,

Ingo