From: Pavel Machek <pavel@ucw.cz>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: kernel list <linux-kernel@vger.kernel.org>, linux-input@vger.kernel.org
Subject: Re: select() on /dev/input/eventX not level-triggered?
Date: Mon, 23 May 2011 22:06:22 +0200 [thread overview]
Message-ID: <20110523200622.GA1590@ucw.cz> (raw)
In-Reply-To: <20110523181312.GA20438@core.coreip.homeip.net>
On Mon 2011-05-23 11:13:12, Dmitry Torokhov wrote:
> On Fri, May 20, 2011 at 01:50:51AM +0200, Pavel Machek wrote:
> > Hi!
> >
> > I'm debugging strange behaviour on /dev/input/eventX ... it seems that
> > select is not behaving level-triggered as it apparently should. I can
> > reproduce it when hitting windows & alt keys.
> >
> > Now, I really should rewrite it into C, first, but perhaps someone has
> > an idea?
(Ok, so we agree that select() should mark descriptor as ready as
long as data are available... right?)
> Is this with next or with mainline? In next we try not to signal that FD
> is ready unless we have full packet in the buffer...
2.6.39-rcX mainline.
> FWIW I see python indeed not reading the tail of events (btw the format
> should be 'llhhi' and the size on 64 bit arches is 24, not 16) but when
> I hacked evtest to use select and non-blockign read it all worked
> properly.
It was on x32, but I'll fix that, thanks.
Difference was I'm not using non-blocking read(). It is unusual but
should work AFAICT. Just read one packet when select shows its ready;
if there's more than one, don't loop around read, but rely on select
returning immediately.
I did verify it on strace, so it should not be python artefact.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2011-05-23 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 23:50 select() on /dev/input/eventX not level-triggered? Pavel Machek
2011-05-23 18:13 ` Dmitry Torokhov
2011-05-23 20:06 ` Pavel Machek [this message]
2011-05-23 20:49 ` Dmitry Torokhov
2011-05-23 21:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523200622.GA1590@ucw.cz \
--to=pavel@ucw.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox