Re: [PATCH 06/18] writeback: sync expired inodes first in background writeback

Wu Fengguang
2011-05-27T15:17:37Z

On Wed, May 25, 2011 at 10:38:57PM +0800, Wu Fengguang wrote:
> On Tue, May 24, 2011 at 11:52:05PM +0800, Jan Kara wrote:
[snip]
> > and I was wondering: Assume there is one continuously redirtied file and
> > untar starts in parallel. With the new logic, background writeback will
> > never consider inodes that are not expired in this situation (we never
> > switch to "all dirty inodes" phase - or even if we switched, we would just
> > queue all inodes and then return back to queueing only expired inodes). So
> > the net effect is that for 30 seconds we will be only continuously writing
> > pages of the continuously dirtied file instead of (possibly older) pages of
> > other files that are written. Is this really desirable? Wasn't the old
> > behavior simpler and not worse than the new one?
>
> Good question! Yes sadly in this case the new behavior could be worse
> than the old one.

Andrew, it's desirable to delay this patch given that it has some
negative behavior (it's fixable but the fix won't be trivial enough
for immediate merge).

You may simply drop this patch (06) and the last two patches (17, 18)
and still be able to cleanly apply all other patches in this series.

Thanks,
Fengguang