[bisected] 2.6.39 breaks floppy

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [bisected] 2.6.39 breaks floppy
@ 2011-05-25 19:16 Ondrej Zary
  2011-05-25 19:37 ` Jens Axboe
  0 siblings, 1 reply; 3+ messages in thread
From: Ondrej Zary @ 2011-05-25 19:16 UTC (permalink / raw)
  To: Tejun Heo; +Cc: Jens Axboe, Kernel development list

Hello,
floppy stopped working in 2.6.39 (confirmed on two machines). 2.6.38 worked 
fine. 
/dev/fd0 is created but does not work (mdir says: "No such device or address", 
mount says "/dev/fd0 is not a valid block device"). dmesg shows no errors:

Floppy drive(s): fd0 is 1.44M
FDC 0 is a post-1991 82077

Bisected it to 9fd097b14918875bd6f125ed699d7bbbba5893ee
(block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers)

Adding the removed line back to floppy.c fixes the problem.

-- 
Ondrej Zary

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [bisected] 2.6.39 breaks floppy
  2011-05-25 19:16 [bisected] 2.6.39 breaks floppy Ondrej Zary
@ 2011-05-25 19:37 ` Jens Axboe
  2011-05-25 20:54   ` Tejun Heo
  0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2011-05-25 19:37 UTC (permalink / raw)
  To: Ondrej Zary; +Cc: Tejun Heo, Kernel development list

On 2011-05-25 21:16, Ondrej Zary wrote:
> Hello,
> floppy stopped working in 2.6.39 (confirmed on two machines). 2.6.38 worked 
> fine. 
> /dev/fd0 is created but does not work (mdir says: "No such device or address", 
> mount says "/dev/fd0 is not a valid block device"). dmesg shows no errors:
> 
> Floppy drive(s): fd0 is 1.44M
> FDC 0 is a post-1991 82077
> 
> Bisected it to 9fd097b14918875bd6f125ed699d7bbbba5893ee
> (block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers)
> 
> Adding the removed line back to floppy.c fixes the problem.

Tejun?

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [bisected] 2.6.39 breaks floppy
  2011-05-25 19:37 ` Jens Axboe
@ 2011-05-25 20:54   ` Tejun Heo
  0 siblings, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2011-05-25 20:54 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Ondrej Zary, Kernel development list

Hello,

On Wed, May 25, 2011 at 9:37 PM, Jens Axboe <jaxboe@fusionio.com> wrote:
>> Bisected it to 9fd097b14918875bd6f125ed699d7bbbba5893ee
>> (block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers)
>>
>> Adding the removed line back to floppy.c fixes the problem.

It's the same one as the following.  Patch posted.  It's caused by
genhd->ev not allocated when ->events | async_events is empty.

  https://bugzilla.kernel.org/show_bug.cgi?id=35832

Will soon post a patch.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-05-25 20:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-25 19:16 [bisected] 2.6.39 breaks floppy Ondrej Zary
2011-05-25 19:37 ` Jens Axboe
2011-05-25 20:54   ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox