From: Harry Wei <jiaweiwei.xiyou@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: oleg@redhat.com, mingo@elte.hu, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] signal.c: fix kernel-doc warning
Date: Thu, 26 May 2011 10:58:08 +0800 [thread overview]
Message-ID: <20110526025806.GA2426@gmail.com> (raw)
In-Reply-To: <20110525192815.01c9227f.randy.dunlap@oracle.com>
On Wed, May 25, 2011 at 07:28:15PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix kernel-doc warnings in signal.c:
>
> Warning(kernel/signal.c:2374): No description found for parameter 'nset'
> Warning(kernel/signal.c:2374): Excess function parameter 'set' description in 'sys_rt_sigprocmask'
Hi Randy,
I wonder how you can get the warning of the comments.
IMO, gcc can not get the comments' errors or warnings. Maybe
you just use scripts for this. Would you mind telling me ;)
Thanks
Harry Wei
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Harry Wei <harryxiyou@gmail.com>
> ---
> kernel/signal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.39-git10.orig/kernel/signal.c
> +++ linux-2.6.39-git10/kernel/signal.c
> @@ -2365,7 +2365,7 @@ int sigprocmask(int how, sigset_t *set,
> /**
> * sys_rt_sigprocmask - change the list of currently blocked signals
> * @how: whether to add, remove, or set signals
> - * @set: stores pending signals
> + * @nset: stores pending signals
> * @oset: previous value of signal mask if non-null
> * @sigsetsize: size of sigset_t type
> */
> --
next prev parent reply other threads:[~2011-05-26 2:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 2:28 [PATCH] signal.c: fix kernel-doc warning Randy Dunlap
2011-05-26 2:58 ` Harry Wei [this message]
2011-05-26 3:01 ` Randy Dunlap
2011-05-26 3:17 ` Harry Wei
2011-05-26 14:45 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526025806.GA2426@gmail.com \
--to=jiaweiwei.xiyou@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox