From: Arnd Bergmann <arnd@arndb.de>
To: GuanXuetao <gxt@mprc.pku.edu.cn>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH 0/6] unicore32 subsystem: 6 patches for 2.6.39
Date: Thu, 26 May 2011 14:50:01 +0200 [thread overview]
Message-ID: <201105261450.01277.arnd@arndb.de> (raw)
In-Reply-To: <cover.1306408804.git.gxt@mprc.pku.edu.cn>
On Thursday 26 May 2011, GuanXuetao wrote:
> Two patches for PKUnity v3 SoC drivers:
> add mac driver, and move rtc driver to appropriate place
> Two patches for new 2.6.39 updates:
> using generic-y and modify PERCPU macro
> Other two patches are small fixes.
>
> ---
> Guan Xuetao (6):
> unicore32: move rtc-puv3.c to drivers/rtc directory
> unicore32: add pkunity-v3 mac/net driver (umal)
> unicore32: change zImage physical address, though it's PIC codes
> unicore32: add KBUILD_DEFCONFIG with unicore32_defconfig (old
> debug_defconfig)
> unicore32: change PERCPU to PERCPU_SECTION
> unicore32: using generic-y format for one line asm-generic files
>
The patches look basically ok, but two points to remember:
* The merge window is not the time to post patches for review, if you
want to collect Acked-by's from other people, do that in the
time between the merge windows, then put the patches in your git
tree with the Acked-by for linux-next. During the merge window, just
send stuff that was already in your tree to Linus.
Bug fixes should get sent to Linus at any time, but I think you already
did that, all of these were either new features or cleanups.
* Add a small text explaining why you do something to each patch. The
one-line summary that you always have is too short for this and only
serves to list what you change, not why.
Arnd
next prev parent reply other threads:[~2011-05-26 12:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 11:36 [PATCH 0/6] unicore32 subsystem: 6 patches for 2.6.39 GuanXuetao
2011-05-26 11:36 ` [PATCH 1/6] unicore32: move rtc-puv3.c to drivers/rtc directory GuanXuetao
2011-05-26 12:40 ` Arnd Bergmann
2011-05-27 3:04 ` Guan Xuetao
2011-05-26 11:36 ` [PATCH 2/6] unicore32: add pkunity-v3 mac/net driver (umal) GuanXuetao
2011-05-26 12:43 ` Arnd Bergmann
2011-05-27 3:08 ` Guan Xuetao
2011-05-26 17:56 ` Ben Hutchings
2011-05-27 4:27 ` Guan Xuetao
2011-05-27 9:19 ` Arnd Bergmann
2011-05-28 2:52 ` Guan Xuetao
2011-05-26 11:36 ` [PATCH 3/6] unicore32: change zImage physical address, though it's PIC codes GuanXuetao
2011-05-26 12:44 ` Arnd Bergmann
2011-05-26 11:36 ` [PATCH 4/6] unicore32: add KBUILD_DEFCONFIG with unicore32_defconfig (old debug_defconfig) GuanXuetao
2011-05-26 12:45 ` Arnd Bergmann
2011-05-26 11:36 ` [PATCH 5/6] unicore32: change PERCPU to PERCPU_SECTION GuanXuetao
2011-05-26 11:46 ` Tejun Heo
2011-05-26 11:36 ` [PATCH 6/6] unicore32: using generic-y format for one line asm-generic files GuanXuetao
2011-05-26 12:45 ` Arnd Bergmann
2011-05-27 3:24 ` Guan Xuetao
2011-05-26 12:50 ` Arnd Bergmann [this message]
2011-05-27 2:58 ` [PATCH 0/6] unicore32 subsystem: 6 patches for 2.6.39 Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105261450.01277.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox