From: Greg KH <greg@kroah.com>
To: Mike Travis <travis@sgi.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Chris Wright <chrisw@sous-sol.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
iommu@lists.linux-foundation.org, Mike Habeck <habeck@sgi.com>,
stable@kernel.org
Subject: Re: [stable] [PATCH 1/7] Intel pci: Check for identity mapping candidate using system dma mask
Date: Fri, 27 May 2011 15:18:38 +0800 [thread overview]
Message-ID: <20110527071838.GA16217@kroah.com> (raw)
In-Reply-To: <20110527013221.405688800@gulag1.americas.sgi.com>
On Thu, May 26, 2011 at 08:32:22PM -0500, Mike Travis wrote:
> The identity mapping code appears to make the assumption that
> if the devices dma_mask is greater than 32bits the device can
> use identity mapping. But that is not true, take the case
> where we have a 40bit device in a 44bit architecture. The
> device can potentially receive a physical address that it
> will truncate and cause incorrect addresses to be used.
>
> Instead check to see if the device's dma_mask is large enough
> to address the system's dma_mask.
>
> From: Chris Wright <chrisw@sous-sol.org>
> Signed-off-by: Mike Travis <travis@sgi.com>
> Reviewed-by: Mike Habeck <habeck@sgi.com>
> ---
> drivers/pci/intel-iommu.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
I'll not send this out for the other 6 patches that also do not follow
the proper format, as I'm sure you would get bored reading them.
next prev parent reply other threads:[~2011-05-27 7:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 1:32 [PATCH 0/7] Intel pci: Fix various problems with Intel IOMMU code Mike Travis
2011-05-27 1:32 ` [PATCH 1/7] Intel pci: Check for identity mapping candidate using system dma mask Mike Travis
2011-05-27 7:18 ` Greg KH [this message]
2011-05-27 9:30 ` [stable] " Ingo Molnar
2011-05-27 9:42 ` Joerg Roedel
2011-05-27 9:59 ` Greg KH
2011-05-27 1:32 ` [PATCH 2/7] Intel pci: Speed up processing of the identity_mapping function Mike Travis
2011-05-27 1:32 ` [PATCH 3/7] Intel pci: Dont cache iova above 32bit Mike Travis
2011-05-27 1:32 ` [PATCH 4/7] Intel pci: Use coherent DMA mask when requested Mike Travis
2011-05-27 1:32 ` [PATCH 5/7] Intel pci: Remove Host Bridge devices from identity mapping Mike Travis
2011-05-27 1:32 ` [PATCH 6/7] Intel pci: Add domain check in domain_remove_one_dev_info Mike Travis
2011-05-27 1:32 ` [PATCH 7/7] Intel pci: Indicate 64-bit IOMMU passthrough available Mike Travis
2011-05-27 15:01 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110527071838.GA16217@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=dwmw2@infradead.org \
--cc=habeck@sgi.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox