From: Greg KH <gregkh@suse.de>
To: Chris Metcalf <cmetcalf@tilera.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Eric Biederman <ebiederm@aristanetworks.com>,
Chris Wright <chrisw@sous-sol.org>,
Benjamin Thery <benjamin.thery@bull.net>,
Phil Carmody <ext-phil.2.carmody@nokia.com>
Subject: Re: [PATCH v2] arch/tile: add hypervisor-based character driver for SPI flash ROM
Date: Sun, 29 May 2011 19:45:17 +0800 [thread overview]
Message-ID: <20110529114517.GA13513@suse.de> (raw)
In-Reply-To: <4DE19407.8040407@tilera.com>
On Sat, May 28, 2011 at 08:32:07PM -0400, Chris Metcalf wrote:
> > As you are only using 1 minor device, why not just use a misc device
> > instead? It's simpler, and you get the sysfs code for free, which you
> > forgot to do, so your device node will never show up in userspace :(
>
> Interesting; this appears to be a bug. We use 4 minors (see "srom_devs =
> 4" higher up). I'll fix this. We may have some other devices that would
> benefit from being recast as misc devices, so I'll look at our set of
> internal devices.
This kind of implies that you didn't test this code, right? You might
want to do that next time :)
> Is there a good example of a character device that has multiple minors and
> also is registered with sysfs?
Lots of them, look all over the kernel, and in LDD3 there's even an
outdated example of one I think.
thanks,
greg k-h
next prev parent reply other threads:[~2011-05-29 11:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 19:10 [PATCH] arch/tile: add arch/tile/drivers/ directory with SROM driver Chris Metcalf
2011-05-05 6:41 ` Arnd Bergmann
2011-05-06 19:37 ` Chris Metcalf
2011-05-20 18:05 ` Chris Metcalf
2011-05-20 18:46 ` Arnd Bergmann
2011-05-20 22:40 ` Eric Biederman
2011-05-20 23:39 ` Chris Metcalf
2011-05-21 3:21 ` Greg KH
2011-05-21 9:33 ` Arnd Bergmann
2011-05-21 13:52 ` Chris Metcalf
2011-05-21 15:02 ` Arnd Bergmann
2011-05-21 15:31 ` Chris Metcalf
2011-05-21 15:50 ` Eric Biederman
2011-05-23 20:10 ` Chris Metcalf
2011-05-28 15:13 ` [PATCH v2] arch/tile: add hypervisor-based character driver for SPI flash ROM Chris Metcalf
2011-05-28 21:23 ` Greg KH
2011-05-29 0:32 ` Chris Metcalf
2011-05-29 11:45 ` Greg KH [this message]
2011-05-29 12:18 ` Chris Metcalf
2011-05-29 13:47 ` Greg KH
2011-05-29 15:45 ` Arnd Bergmann
2011-05-29 18:23 ` Chris Metcalf
2011-06-02 15:04 ` [PATCH v3] " Chris Metcalf
2011-06-10 16:41 ` Arnd Bergmann
2011-05-21 7:46 ` [PATCH] arch/tile: add arch/tile/drivers/ directory with SROM driver Eric Biederman
2011-05-21 8:32 ` Arnd Bergmann
2011-05-22 0:54 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110529114517.GA13513@suse.de \
--to=gregkh@suse.de \
--cc=arnd@arndb.de \
--cc=benjamin.thery@bull.net \
--cc=chrisw@sous-sol.org \
--cc=cmetcalf@tilera.com \
--cc=ebiederm@aristanetworks.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).