Re: [PATCH 3/9] [SCSI] mvsas: Add driver version and interrupt coalescing to device attributes in sysfs

[Greg KH <greg@kroah.com>]

On Mon, May 30, 2011 at 12:26:48AM -0700, Xiangliang Yu wrote:
> >> +What:          /sys/devices/pci/<devices>/<dev>/host/scsi_host/host/interrupt_coalescing
> >> +Date:          May 2011
> >> +Kernel Version:        2.6.39
> 
> >2.6.39 was released already, is this file in that release?
> Yes.

How, doesn't your patch below implement that option?  How can it already
be in the .39 kernel?

> >> +Contact:       yuxiangl@marvell.com
> >> +Description:   Determines the maximum time the 88SE94XX waits after the occurrence of a
> >> +               Command Done before generating an interrupt.The maximum number of the 
> >> +               variable is less than 0x10000.
> 
> >Why would a user, or anyone else, ever want to be able to change this?
> Because different platform can get better performance by setting different value

Then you need to document _how_ to do this tuning, and why someone would
want to, and lots of other stuff.  Don't just blindly let userspace
change a value that they know nothing about.

> >Why wouldn't this just be something that the driver handles
> >automagically so the user never has to worry about it at all?
> As for now, driver can't do it. The value need to be test, and get the best.

Why don't you test it and set it to the proper value now?  What would
change in a user's system that require this to be changed?  Size of the
machine?  Number of disks?  Something else?

It really should be automatic, people do not ever want to have to
manually tune their machines anymore they should be smart enough to
determine the load on them and make the changes without any user needing
to do it for them.

thanks,

greg k-h