Re: [PATCH -tip v4 0/7] perf: Introduce branch sub commands

[Arnaldo Carvalho de Melo <acme@infradead.org>]

Em Mon, May 30, 2011 at 06:11:49PM +0200, Frederic Weisbecker escreveu:
> On Mon, May 30, 2011 at 09:26:28AM -0600, David Ahern wrote:
> > On 05/30/2011 07:31 AM, Akihiro Nagai wrote:
> > >> The sample address can be converted to symbols and the output can be
> > >> added to perf-script rather easily. Attached is an example. I was going
> > >> to submit it back in April and got distracted. I'll rebase, move the
> > >> addr->sym conversion to a function and submit later today.
> > > OK.
> > > I agreed with implementing it on perf script.
> > > I'd like to try it.
> > 
> > Updated patch. It applies on top of:
> >   http://lkml.org/lkml/2011/5/27/385
> > 
> > Hopefully for BTS you only have to change the sample_addr_correlates_sym
> > function.
> > 
> > I still need to look into out why some of the addresses for page-faults
> > are not resolving to symbols.
> 
> Perhaps it only resolves instruction faults because you only resolve with
> MAP__FUNCTION. You can try MAP__VARIABLE as well when that fails.
> 
> But that is going to only help with faults on global vars, ie: only
> a few part of them. Further information would require some dwarf processing.
> 
> Your patch looks good though. Mind resending it with appropriate title/changelog
> and signed-off-by tag?

Just for reference: I thought about removing this split but David Miller
told me that there are architectures where we can't do that, i.e. there
is no guarantee of an unified addr space for variables and code, such as
SPARC.

- Arnaldo