From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Andrew Morton <akpm@linux-foundation.org>,
kernel@pengutronix.de
Subject: Re: [PATCH] leds: make LEDS_GPIO_REGISTER depend on NEW_LEDS
Date: Tue, 31 May 2011 08:52:28 +0200 [thread overview]
Message-ID: <20110531065228.GS9907@pengutronix.de> (raw)
In-Reply-To: <BANLkTi=F2Gh=+-8ms0nBf+zdLy+7uEOugg@mail.gmail.com>
On Sun, May 29, 2011 at 09:38:34AM +0800, Axel Lin wrote:
> hi Uwe,
> > Below is a patch that fixes the layout problem but keeps the
> > functionality as before and intended.
> >
> > -----8<-----
> > leds: move LEDS_GPIO_REGISTER out of menuconfig NEW_LEDS
> >
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > Commit 4440673a "leds: provide helper to register "leds-gpio" devices"
> > broke the display of the NEW_LEDS menu as it didn't depend on NEW_LEDS
> > and so made "LED drivers" and "LED Triggers" appear at the same level as
> > "LED Support" instead of below it as it was before 4440673a.
> >
> > Moving LEDS_GPIO_REGISTER out of the menuconfig NEW_LEDS fixes this
> > unintended side effect.
> >
> > Reported-by: Axel Lin <axel.lin@gmail.com>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> Your patch looks good.
Richard, thoughts? Andrew, do you take my patch provided that Richard is
OK with it?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2011-05-31 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 9:52 [PATCH] leds: make LEDS_GPIO_REGISTER depend on NEW_LEDS Axel Lin
2011-05-28 17:47 ` Uwe Kleine-König
2011-05-29 1:38 ` Axel Lin
2011-05-31 6:52 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531065228.GS9907@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox