From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755256Ab1EaNST (ORCPT ); Tue, 31 May 2011 09:18:19 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:13009 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754346Ab1EaNSQ (ORCPT ); Tue, 31 May 2011 09:18:16 -0400 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 98.234.237.12 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+6qeQytBrE6TpmqYJWPTzy Date: Tue, 31 May 2011 06:18:12 -0700 From: Tony Lindgren To: Axel Lin Cc: linux-kernel@vger.kernel.org, Syed Mohammed Khasim , Grazvydas Ignotas , Steve Sakoman , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] ARM: OMAP2: Add missing include of linux/gpio.h Message-ID: <20110531131812.GP11352@atomide.com> References: <1306846544.30148.1.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1306846544.30148.1.camel@phoenix> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Axel Lin [110531 05:51]: > I got some build error like below while executing "make omap2plus_defconfig". > > CC arch/arm/mach-omap2/board-2430sdp.o > arch/arm/mach-omap2/board-2430sdp.c: In function 'omap_2430sdp_init': > arch/arm/mach-omap2/board-2430sdp.c:247: error: 'GPIOF_OUT_INIT_LOW' undeclared (first use in this function) > arch/arm/mach-omap2/board-2430sdp.c:247: error: (Each undeclared identifier is reported only once > arch/arm/mach-omap2/board-2430sdp.c:247: error: for each function it appears in.) > > This patch fixes the build error by include linux/gpio.h instead of mach/gpio.h. Does this happen with next? Will queue as a fix anyways. Tony