Re: [PATCH 1/4] Cache xattr security drop check for write v2

Al Viro
2011-05-31T20:21:40Z

On Tue, May 31, 2011 at 10:18:34PM +0200, Andi Kleen wrote:
> On Tue, May 31, 2011 at 09:07:50PM +0100, Al Viro wrote:
> > On Tue, May 31, 2011 at 07:42:26PM +0100, Steven Whitehouse wrote:
> >
> > > Yes, it should test for xattr too,
> >
> > Frankly, I suspect that the sanest way to handle that is this:
> > * new superblock flag - MS_NOSEC
> > * S_NOSEC is never set unless we have MS_NOSEC
> > * mount_bdev() sets it before calling fill_super callback.
> > * ocfs2 and fuse *clear* it in their fill_super
>
> gfs2 needs to clear it too (unless Steven's updated patch goes in too)
> Steven?

gfs2 doesn't use mount_bdev(), so there's nothing that would set it (we
never pass it set in flags - mount(2) clears all but user-settable bits).