Re: [PATCH 1/4] Cache xattr security drop check for write v2

Andi Kleen
2011-06-18T18:04:54Z

> several fs now uses MS_NOSEC (because this flag is set in mount_bdev())
> but I don't see any user of the function inode_has_no_xattr() in the
> latest version. If I well understand, a fs that wants to manage this
> feature has to set MS_NOSEC and calls when needed this function, isn't
> it? So at this point, why there aren't any user of this function?

Calling the function is just an optimization to avoid the lookup
for the first write. But most of the benefit you already get
when just the flag is set.

I haven't resent the patches using it to the fs maintainers yet and none
of them took it the first round.

-Andi