[PATCH] init, calibrate: Drop annoying warning

[PATCH] init, calibrate: Drop annoying warning

[Borislav Petkov]

From: Borislav Petkov <borislav.petkov@amd.com>

Even though the error message is KERN_DEBUG, it appears when booting
every core on setups with 'ignore_loglevel' for people who want to test
latest kernels and scan dmesg for possible issues. Also, it doesn't show
very useful information to the widest audience of kernel boot message
gazers so drop it.

Introduced by d2b463135f84d15808163cd15638b108e323d3e7.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 init/calibrate.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/init/calibrate.c b/init/calibrate.c
index cfd7000..2568d22 100644
--- a/init/calibrate.c
+++ b/init/calibrate.c
@@ -93,9 +93,6 @@ static unsigned long __cpuinit calibrate_delay_direct(void)
 		 * If the upper limit and lower limit of the timer_rate is
 		 * >= 12.5% apart, redo calibration.
 		 */
-		printk(KERN_DEBUG "calibrate_delay_direct() timer_rate_max=%lu "
-			    "timer_rate_min=%lu pre_start=%lu pre_end=%lu\n",
-			  timer_rate_max, timer_rate_min, pre_start, pre_end);
 		if (start >= post_end)
 			printk(KERN_NOTICE "calibrate_delay_direct() ignoring "
 					"timer_rate as we had a TSC wrap around"
-- 
1.7.4.rc2

Re: [PATCH] init, calibrate: Drop annoying warning

[Andrew Worsley]

I can see your point - it's useful when debugging the bogomips issue -
but if it's working it's not relevant.
Would be nice to have an extra level of verbose debug or a debug
branch of the file or perhaps just a relevant comment
that would easily allow it to be found and reverted to re-enable debug
if people want to debug this stuff again.

That said I would suggest just changing the comment (I don't know how
to just submit a comment change?) to something like:

"Drop calibrate_delay_direct() KERN_DEBUG printk related to bogomips
calculation as it appears when booting
every core on setups with 'ignore_loglevel' for people who want to
test latest kernels and scan dmesg for possible issues.
and this information isn't very useful to the widest audience of
kernel boot message gazers."

which would allow an easy revert locally when ever it was deemed useful.

On 1 June 2011 04:29, Borislav Petkov <bp@amd64.org> wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
>
> Even though the error message is KERN_DEBUG, it appears when booting
> every core on setups with 'ignore_loglevel' for people who want to test
> latest kernels and scan dmesg for possible issues. Also, it doesn't show
> very useful information to the widest audience of kernel boot message
> gazers so drop it.
>
> Introduced by d2b463135f84d15808163cd15638b108e323d3e7.
>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
> ---
>  init/calibrate.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/init/calibrate.c b/init/calibrate.c
> index cfd7000..2568d22 100644
> --- a/init/calibrate.c
> +++ b/init/calibrate.c
> @@ -93,9 +93,6 @@ static unsigned long __cpuinit calibrate_delay_direct(void)
>                 * If the upper limit and lower limit of the timer_rate is
>                 * >= 12.5% apart, redo calibration.
>                 */
> -               printk(KERN_DEBUG "calibrate_delay_direct() timer_rate_max=%lu "
> -                           "timer_rate_min=%lu pre_start=%lu pre_end=%lu\n",
> -                         timer_rate_max, timer_rate_min, pre_start, pre_end);
>                if (start >= post_end)
>                        printk(KERN_NOTICE "calibrate_delay_direct() ignoring "
>                                        "timer_rate as we had a TSC wrap around"
> --
> 1.7.4.rc2
>
>

Hopefully the code is working and the KERN_NOTICE is considered useful
to indicate to people it recovering from the problem on other machines
besides my own.

Andrew

Re: [PATCH] init, calibrate: Drop annoying warning

[Borislav Petkov]

On Tue, May 31, 2011 at 07:04:59PM -0400, Andrew Worsley wrote:
> I can see your point - it's useful when debugging the bogomips issue -
> but if it's working it's not relevant.
> Would be nice to have an extra level of verbose debug or a debug
> branch of the file or perhaps just a relevant comment
> that would easily allow it to be found and reverted to re-enable debug
> if people want to debug this stuff again.

Well, your patch either fixes the issue so the debug statements can go
or it doesn't and needs more hammering :).

> That said I would suggest just changing the comment (I don't know how
> to just submit a comment change?) to something like:
> 
> "Drop calibrate_delay_direct() KERN_DEBUG printk related to bogomips
> calculation as it appears when booting
> every core on setups with 'ignore_loglevel' for people who want to
> test latest kernels and scan dmesg for possible issues.
> and this information isn't very useful to the widest audience of
> kernel boot message gazers."

Fair enough, will change and resubmit.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[PATCH v1.1] init, calibrate: Drop annoying printk

[Borislav Petkov]

From: Borislav Petkov <borislav.petkov@amd.com>

Drop calibrate_delay_direct() KERN_DEBUG printk related to bogomips
calculation as it appears when booting every core on setups with
'ignore_loglevel' which dmesg people scan for possible issues. As the
message doesn't show very useful information to the widest audience of
kernel boot message gazers, it should be removed.

Introduced by d2b463135f84d15808163cd15638b108e323d3e7.

Cc: Andrew Worsley <amworsley@gmail.com>
Cc: Phil Carmody <ext-phil.2.carmody@nokia.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 init/calibrate.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/init/calibrate.c b/init/calibrate.c
index cfd7000..2568d22 100644
--- a/init/calibrate.c
+++ b/init/calibrate.c
@@ -93,9 +93,6 @@ static unsigned long __cpuinit calibrate_delay_direct(void)
 		 * If the upper limit and lower limit of the timer_rate is
 		 * >= 12.5% apart, redo calibration.
 		 */
-		printk(KERN_DEBUG "calibrate_delay_direct() timer_rate_max=%lu "
-			    "timer_rate_min=%lu pre_start=%lu pre_end=%lu\n",
-			  timer_rate_max, timer_rate_min, pre_start, pre_end);
 		if (start >= post_end)
 			printk(KERN_NOTICE "calibrate_delay_direct() ignoring "
 					"timer_rate as we had a TSC wrap around"
-- 
1.7.4.rc2