From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754746Ab1FAGqP (ORCPT ); Wed, 1 Jun 2011 02:46:15 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:13368 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752302Ab1FAGqK (ORCPT ); Wed, 1 Jun 2011 02:46:10 -0400 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 72.249.23.125 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+JFAeCIr2xMFeHdA23gvhQ Date: Wed, 1 Jun 2011 09:46:06 +0300 From: Tony Lindgren To: Colin Cross Cc: "linux-arm-kernel@lists.infradead.org" , Russell King , l-o , lkml Subject: Re: [PATCH] ARM: omap4: Pass core and wakeup mux tables to omap4_mux_init Message-ID: <20110601064606.GC8696@atomide.com> References: <1304546278-28965-1-git-send-email-ccross@android.com> <20110531124208.GF11352@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Colin Cross [110531 21:46]: > On Tue, May 31, 2011 at 5:42 AM, Tony Lindgren wrote: > > * Colin Cross [110504 14:54]: > >> OMAP4 contains two separate instances of the padconf registers, > >> one in the core system config and one in the wakeup system config. > >> Pass in two tables to apply the correct values to each instance. > > > > Hmm good catch thanks. Will queue this as a fix. > > This patch doesn't work without another fix to allow NULL to be passed > to omap4_mux_init. Do you prefer allowing NULL, or adding empty > board_wkup_mux arrays to every board file? I have a patch for the > first option. OK, saw that patch and adding to fixes. Passing NULL here is fine. Tony