From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf: Split up buffer handling from core code
Date: Wed, 1 Jun 2011 09:06:16 +0200 [thread overview]
Message-ID: <20110601070616.GA32308@elte.hu> (raw)
In-Reply-To: <20110531182252.GA5256@somewhere.redhat.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Thu, May 19, 2011 at 07:55:04PM +0200, Frederic Weisbecker wrote:
> > And create the internal perf events header.
> >
> > v2: Keep an internal inlined perf_output_copy()
> >
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Stephane Eranian <eranian@google.com>
> > ---
>
> Are you guys fine with his patch?
> If so, should I queue it myself and send a pull request?
Yeah, please do it ASAP.
> I prefer to work step by step on this split, to avoid too much
> review burden. And also a single detail can require to rework the
> whole.
Please lets just start it so that the interactions get smaller!
core.c couldnt be uglier as it is today, so after a first raw split
we can sort out any fine details - just make sure you don't break the
build.
Thanks,
Ingo
next prev parent reply other threads:[~2011-06-01 7:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 1:06 [RFC PATCH] perf: Split up buffer handling from core code Frederic Weisbecker
2011-05-19 1:07 ` Frederic Weisbecker
2011-05-19 7:31 ` Borislav Petkov
2011-05-19 8:32 ` Peter Zijlstra
2011-05-19 14:14 ` Frederic Weisbecker
2011-05-19 14:43 ` Peter Zijlstra
2011-05-19 14:59 ` Frederic Weisbecker
2011-05-19 15:14 ` Peter Zijlstra
2011-05-19 15:15 ` Frederic Weisbecker
2011-05-19 17:20 ` Ingo Molnar
2011-05-19 17:23 ` Frederic Weisbecker
2011-05-19 17:55 ` [PATCH] " Frederic Weisbecker
2011-05-31 18:22 ` Frederic Weisbecker
2011-06-01 7:06 ` Ingo Molnar [this message]
2011-06-09 11:43 ` [tip:perf/core] " tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601070616.GA32308@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox