public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
	Dave Chinner <david@fromorbit.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/18] writeback fixes and cleanups for 2.6.40 (v3)
Date: Wed, 1 Jun 2011 15:31:42 -0700	[thread overview]
Message-ID: <20110601153142.0bf83332.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110524032859.GA17429@localhost>

On Tue, 24 May 2011 11:28:59 +0800
Wu Fengguang <fengguang.wu@intel.com> wrote:

> On Mon, May 23, 2011 at 05:28:38PM +0800, Wu Fengguang wrote:
> > On Mon, May 23, 2011 at 05:07:39PM +0800, Christoph Hellwig wrote:
> > > Wu, Andrew,
> > > 
> > > what's the plan for these for 2.6.40?  We'll need to make some progress
> > > in this area, and even if we can't get everything it we should make sure
> > > to at least include the updated versions of those in -mm.  But even
> > > some of the later ones are pretty low risk.

I've been waiting for this work to stabilize a bit more.

> > Yes, except for patch 14 which does not include external behavior
> > changes besides the good full write chunk size for large files, the
> > patches not in -mm are pretty trivial ones.
> > 
> > Aside from my simple tests, Alex also helped going through the LKP
> > tests with the patchset and find no writeback regressions.
> 
> I'll rearrange the series and move patch 14 to the end, so that the
> patches come in order
> 
> - 10 (updated) patches in -mm
> - 6 more trivial patches that is safe to go upstream after -rc1 
> - the current patch 14 and patch 16 (that depends on 14)

I didn't merge the writeback patches for -rc1 due to uncertainty about
their readiness.  Here's what I'm sitting on:


writeback-pass-writeback_control-down-to-move_expired_inodes.patch
writeback-introduce-writeback_controlinodes_cleaned.patch
writeback-try-more-writeback-as-long-as-something-was-written.patch
writeback-the-kupdate-expire-timestamp-should-be-a-moving-target.patch
writeback-sync-expired-inodes-first-in-background-writeback.patch
writeback-refill-b_io-iff-empty.patch
writeback-split-inode_wb_list_lock-into-bdi_writebacklist_lock.patch
writeback-elevate-queue_io-into-wb_writeback.patch
writeback-introduce-wbctagged_sync-for-the-wb_sync_none-sync-stage.patch
writeback-update-dirtied_when-for-synced-inode-to-prevent-livelock.patch
writeback-avoid-extra-sync-work-at-enqueue-time.patch

Are these all up-todate and considered ready to go?


I have a couple of notes I made:

#writeback-try-more-writeback-as-long-as-something-was-written.patch: sync livelocks

IOW, someone reported livelocks with sync, or speculated that it might
cause them.

#writeback-sync-expired-inodes-first-in-background-writeback.patch: TBU??

"to be updated".

I haven't gone back through the email trail to work out why I added
these notes and whether the identified issues were resolved.


  reply	other threads:[~2011-06-01 22:32 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 21:45 [PATCH 00/18] writeback fixes and cleanups for 2.6.40 (v3) Wu Fengguang
2011-05-19 21:45 ` [PATCH 01/18] writeback: introduce .tagged_writepages for the WB_SYNC_NONE sync stage Wu Fengguang
2011-05-19 21:45 ` [PATCH 02/18] writeback: update dirtied_when for synced inode to prevent livelock Wu Fengguang
2011-05-19 21:45 ` [PATCH 03/18] writeback: introduce writeback_control.inodes_cleaned Wu Fengguang
2011-05-19 21:45 ` [PATCH 04/18] writeback: try more writeback as long as something was written Wu Fengguang
2011-05-19 21:45 ` [PATCH 05/18] writeback: the kupdate expire timestamp should be a moving target Wu Fengguang
2011-05-19 21:45 ` [PATCH 06/18] writeback: sync expired inodes first in background writeback Wu Fengguang
2011-05-19 21:45 ` [PATCH 07/18] writeback: refill b_io iff empty Wu Fengguang
2011-05-19 21:45 ` [PATCH 08/18] writeback: split inode_wb_list_lock into bdi_writeback.list_lock Wu Fengguang
2011-05-19 21:45 ` [PATCH 09/18] writeback: elevate queue_io() into wb_writeback() Wu Fengguang
2011-05-19 21:45 ` [PATCH 10/18] writeback: avoid extra sync work at enqueue time Wu Fengguang
2011-05-19 21:45 ` [PATCH 11/18] writeback: add bdi_dirty_limit() kernel-doc Wu Fengguang
2011-05-19 21:45 ` [PATCH 12/18] writeback: skip balance_dirty_pages() for in-memory fs Wu Fengguang
2011-05-19 21:45 ` [PATCH 13/18] writeback: remove writeback_control.more_io Wu Fengguang
2011-05-19 21:45 ` [PATCH 14/18] writeback: make writeback_control.nr_to_write straight Wu Fengguang
2011-05-19 22:06   ` Wu Fengguang
2011-05-19 23:29     ` Dave Chinner
2011-05-20  4:07       ` Wu Fengguang
2011-05-20  6:52         ` Dave Chinner
2011-05-20  7:15           ` Wu Fengguang
2011-05-20  7:26             ` Wu Fengguang
2011-05-19 21:45 ` [PATCH 15/18] writeback: remove .nonblocking and .encountered_congestion Wu Fengguang
2011-05-19 21:45 ` [PATCH 16/18] writeback: trace event writeback_single_inode Wu Fengguang
2011-05-19 21:45 ` [PATCH 17/18] writeback: trace event writeback_queue_io Wu Fengguang
2011-05-19 21:45 ` [PATCH 18/18] writeback: rearrange the wb_writeback() loop Wu Fengguang
2011-05-23  9:07 ` [PATCH 00/18] writeback fixes and cleanups for 2.6.40 (v3) Christoph Hellwig
2011-05-23  9:28   ` Wu Fengguang
2011-05-24  3:28     ` Wu Fengguang
2011-06-01 22:31       ` Andrew Morton [this message]
2011-06-02  2:29         ` Wu Fengguang
2011-06-07 12:13           ` writeback merge status, was " Christoph Hellwig
2011-06-07 20:15             ` Andrew Morton
2011-06-07 21:11               ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110601153142.0bf83332.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=fengguang.wu@intel.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox