[PATCH] Fix compiler warning in ftrace.c

[PATCH] Fix compiler warning in ftrace.c

[GuoWen Li]

kernel/trace/ftrace.c: In function ‘ftrace_regex_write.clone.15’:
kernel/trace/ftrace.c:2743:6: warning: ‘ret’ may be used uninitialized in this 
function

Signed-off-by: GuoWen Li
---
 kernel/trace/ftrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 1ee417f..204b3eb 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -2740,7 +2740,7 @@ static int ftrace_process_regex(struct ftrace_hash 
*hash,
 {
        char *func, *command, *next = buff;
        struct ftrace_func_command *p;
-       int ret;
+       int ret = -EINVAL;
 
        func = strsep(&next, ":");

Re: [PATCH] Fix compiler warning in ftrace.c

[Steven Rostedt]

On Wed, 2011-06-01 at 19:18 +0800, GuoWen Li wrote:
> kernel/trace/ftrace.c: In function ‘ftrace_regex_write.clone.15’:
> kernel/trace/ftrace.c:2743:6: warning: ‘ret’ may be used uninitialized in this 
> function

Thanks, but this isn't just a fix of a warning, it fixes an actual bug.

-- Steve

> 
> Signed-off-by: GuoWen Li
> ---
>  kernel/trace/ftrace.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 1ee417f..204b3eb 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -2740,7 +2740,7 @@ static int ftrace_process_regex(struct ftrace_hash 
> *hash,
>  {
>         char *func, *command, *next = buff;
>         struct ftrace_func_command *p;
> -       int ret;
> +       int ret = -EINVAL;
>  
>         func = strsep(&next, ":");

Re: [PATCH] Fix compiler warning in ftrace.c

[Steven Rostedt]

Couple of things:

On Wed, 2011-06-01 at 19:18 +0800, GuoWen Li wrote:
> kernel/trace/ftrace.c: In function ‘ftrace_regex_write.clone.15’:
> kernel/trace/ftrace.c:2743:6: warning: ‘ret’ may be used uninitialized in this 
> function
> 
> Signed-off-by: GuoWen Li

Please add your mail address to your SOB. (I'll fix it)

> ---
>  kernel/trace/ftrace.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 1ee417f..204b3eb 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -2740,7 +2740,7 @@ static int ftrace_process_regex(struct ftrace_hash 
> *hash,
>  {
>         char *func, *command, *next = buff;
>         struct ftrace_func_command *p;
> -       int ret;
> +       int ret = -EINVAL;

This patch has horrible white space issues. (I fixed it)

-- Steve


>  
>         func = strsep(&next, ":");

Re: [PATCH] Fix compiler warning in ftrace.c

[Guowen Li]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 1492 bytes --]

Thank you for pointing them out, i will be careful next time. :)

Signed-off-by: Guowen Li <guowen.li.linux@gmail.com>
----- Original Message ----- 
From: "Steven Rostedt" <rostedt@goodmis.org>
To: "GuoWen Li" <guowen.li.linux@gmail.com>
Cc: <linux-kernel@vger.kernel.org>
Sent: Friday, June 03, 2011 10:50 AM
Subject: Re: [PATCH] Fix compiler warning in ftrace.c


> Couple of things:
> 
> On Wed, 2011-06-01 at 19:18 +0800, GuoWen Li wrote:
>> kernel/trace/ftrace.c: In function ‘ftrace_regex_write.clone.15’:
>> kernel/trace/ftrace.c:2743:6: warning: ‘ret’ may be used uninitialized in this 
>> function
>> 
>> Signed-off-by: GuoWen Li
> 
> Please add your mail address to your SOB. (I'll fix it)
> 
>> ---
>>  kernel/trace/ftrace.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
>> index 1ee417f..204b3eb 100644
>> --- a/kernel/trace/ftrace.c
>> +++ b/kernel/trace/ftrace.c
>> @@ -2740,7 +2740,7 @@ static int ftrace_process_regex(struct ftrace_hash 
>> *hash,
>>  {
>>         char *func, *command, *next = buff;
>>         struct ftrace_func_command *p;
>> -       int ret;
>> +       int ret = -EINVAL;
> 
> This patch has horrible white space issues. (I fixed it)
> 
> -- Steve
> 
> 
>>  
>>         func = strsep(&next, ":");
> 
> 
>ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

[tip:perf/urgent] ftrace: Fix possible undefined return code

[tip-bot for GuoWen Li]

Commit-ID:  0aff1c0cef13b34c17e81a502336fad738151c37
Gitweb:     http://git.kernel.org/tip/0aff1c0cef13b34c17e81a502336fad738151c37
Author:     GuoWen Li <guowen.li.linux@gmail.com>
AuthorDate: Wed, 1 Jun 2011 19:18:47 +0800
Committer:  Steven Rostedt <rostedt@goodmis.org>
CommitDate: Mon, 6 Jun 2011 22:34:25 -0400

ftrace: Fix possible undefined return code

kernel/trace/ftrace.c: In function 'ftrace_regex_write.clone.15':
kernel/trace/ftrace.c:2743:6: warning: 'ret' may be used uninitialized in this
function

Signed-off-by: GuoWen Li <guowen.li.linux@gmail.com>
Link: http://lkml.kernel.org/r/201106011918.47939.guowen.li.linux@gmail.com
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/ftrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 1ee417f..204b3eb 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -2740,7 +2740,7 @@ static int ftrace_process_regex(struct ftrace_hash *hash,
 {
 	char *func, *command, *next = buff;
 	struct ftrace_func_command *p;
-	int ret;
+	int ret = -EINVAL;
 
 	func = strsep(&next, ":");