From: "Michael S. Tsirkin" <mst@redhat.com>
To: Mark Wu <dwu@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index
Date: Thu, 2 Jun 2011 13:34:06 +0300 [thread overview]
Message-ID: <20110602103406.GD7943@redhat.com> (raw)
In-Reply-To: <4DE5F78C.1010102@redhat.com>
On Wed, Jun 01, 2011 at 04:25:48AM -0400, Mark Wu wrote:
> On 06/01/2011 03:24 AM, Mark Wu wrote:
> >- if (index_to_minor(index)>= 1<< MINORBITS)
> >- return -ENOSPC;
> >+ do {
> >+ if (!ida_pre_get(&vd_index_ida, GFP_KERNEL))
> >+ return err;
> >+
> There's a problem in above code: err is not initialized before
> using, so change it to return -1;
> + do {
> + if (!ida_pre_get(&vd_index_ida, GFP_KERNEL))
> + return -1;
Not -1. Pls return -ENOMEM.
next prev parent reply other threads:[~2011-06-02 10:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 7:24 [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index Mark Wu
2011-06-01 8:25 ` Mark Wu
2011-06-02 10:34 ` Michael S. Tsirkin [this message]
2011-06-08 13:12 ` Mark Wu
2011-06-01 23:57 ` Rusty Russell
2011-06-08 13:08 ` Mark Wu
2011-06-08 23:21 ` Rusty Russell
2011-06-08 23:45 ` Greg KH
2011-06-09 9:14 ` Tejun Heo
2011-06-09 10:41 ` Mark Wu
2011-06-15 4:51 ` Rusty Russell
2011-06-15 7:06 ` Tejun Heo
2011-06-16 0:05 ` Rusty Russell
2011-06-16 7:46 ` Tejun Heo
2011-10-19 10:12 ` Michael S. Tsirkin
2011-10-24 10:02 ` Michael S. Tsirkin
2011-10-24 10:02 ` Jens Axboe
2011-10-25 1:07 ` Rusty Russell
2011-06-02 10:33 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110602103406.GD7943@redhat.com \
--to=mst@redhat.com \
--cc=dwu@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).