From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
linux-cris-kernel@axis.com, LKML <linux-kernel@vger.kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Mikael Starvik" <starvik@axis.com>,
"Jesper Nilsson" <jesper.nilsson@axis.com>
Subject: Re: [Patch] cris: add missing declaration of kgdb_init() and breakpoint()
Date: Thu, 2 Jun 2011 22:31:41 +0800 [thread overview]
Message-ID: <20110602143141.GD4416@cr0.redhat.com> (raw)
In-Reply-To: <20110601151618.15759bfb.akpm@linux-foundation.org>
On Wed, Jun 01, 2011 at 03:16:18PM -0700, Andrew Morton wrote:
>On Sun, 22 May 2011 22:42:56 +0800
>Am__rico Wang <xiyou.wangcong@gmail.com> wrote:
>
>> --- a/arch/cris/arch-v10/kernel/irq.c
>> +++ b/arch/cris/arch-v10/kernel/irq.c
>> @@ -20,6 +20,9 @@
>> #define crisv10_mask_irq(irq_nr) (*R_VECT_MASK_CLR = 1 << (irq_nr));
>> #define crisv10_unmask_irq(irq_nr) (*R_VECT_MASK_SET = 1 << (irq_nr));
>>
>> +extern void kgdb_init(void);
>> +extern void breakpoint(void);
>
>They should be declared in a header file, please.
>arch/cris/arch-v32/kernel/irq.c has a private declaration of
>kgdb_init(), too.
>
Yeah, but I don't find a proper header to declare them.
Thanks.
next prev parent reply other threads:[~2011-06-02 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 14:42 [Patch] cris: add missing declaration of kgdb_init() and breakpoint() Américo Wang
2011-06-01 22:16 ` Andrew Morton
2011-06-02 14:31 ` Américo Wang [this message]
2011-06-02 17:21 ` Andrew Morton
2011-06-03 15:32 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110602143141.GD4416@cr0.redhat.com \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=jesper.nilsson@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox