Re: [patch 0/8] mm: memcg naturalization -rc2

Christoph Hellwig
2011-06-09T09:31:48Z

On Thu, Jun 09, 2011 at 10:43:00AM +0200, Johannes Weiner wrote:
> I think it's much more natural to do it that way, but it's not a
> requirement as such. We could just keep the extra soft limit reclaim
> invocation in kswapd that looks for the biggest offender and the
> hierarchy below it, then does a direct call to do_shrink_zone() to
> bypass the generic hierarchy walk.
>
> It's not very nice to have that kind of code duplication, but it's
> possible to leave it like that for now.

Unless there is a really good reason please kill it. It just means more
codepathes that eat away tons of stack in the reclaim path, and we
already have far too much of those, and more code that needs fixing for
all the reclaim issues we have. Nevermind that the cgroups code
generally gets a lot less testing, so the QA overhead is also much
worse.