public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jack Steiner <steiner@sgi.com>
Cc: tglx@linutronix.de, hpa@zytor.com, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x66, UV: Enable 64-bit ACPI MFCG support for SGI UV2 platform
Date: Fri, 3 Jun 2011 10:28:45 +0200	[thread overview]
Message-ID: <20110603082845.GC16694@elte.hu> (raw)
In-Reply-To: <20110602195943.GA27079@sgi.com>


* Jack Steiner <steiner@sgi.com> wrote:

> Enable 64-bit ACPI MFCG support for SGI UV2 platform. The check is similar
> to the check on UV1. UV2 has a different oem_id string.
> 
> Signed-off-by: Jack Steiner <steiner@sgi.com>
> 
> 
> ---
>  arch/x86/pci/mmconfig-shared.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux/arch/x86/pci/mmconfig-shared.c
> ===================================================================
> --- linux.orig/arch/x86/pci/mmconfig-shared.c	2011-05-31 12:13:19.635285219 -0500
> +++ linux/arch/x86/pci/mmconfig-shared.c	2011-06-02 14:41:26.645034257 -0500
> @@ -519,7 +519,8 @@ static int __init acpi_mcfg_check_entry(
>  	if (cfg->address < 0xFFFFFFFF)
>  		return 0;
>  
> -	if (!strcmp(mcfg->header.oem_id, "SGI"))
> +	if (!strcmp(mcfg->header.oem_id, "SGI") ||
> +	    		!strcmp(mcfg->header.oem_id, "SGI2"))

Wouldnt strncmp(,,3) cover any future SGI3, SGI4 strings as well?

Thanks,

	Ingo

  reply	other threads:[~2011-06-03  8:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 19:59 [PATCH] x66, UV: Enable 64-bit ACPI MFCG support for SGI UV2 platform Jack Steiner
2011-06-03  8:28 ` Ingo Molnar [this message]
2011-06-03 13:17   ` Jack Steiner
2011-06-03 14:03 ` [tip:x86/uv] " tip-bot for Jack Steiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110603082845.GC16694@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox