From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawn.guo@linaro.org>,
patches@linaro.org, linux-kernel@vger.kernel.org,
grant.likely@secretlab.ca, kernel@pengutronix.de, olof@lixom.net
Subject: Re: [PATCH v2 3/4] ARM: mxc: migrate mach-imx gpio driver to gpio-mxc
Date: Fri, 3 Jun 2011 13:23:00 +0000 [thread overview]
Message-ID: <201106031323.01024.arnd@arndb.de> (raw)
In-Reply-To: <BANLkTikUnDN81f3cv-buqsKUgdqXsRcYhQ@mail.gmail.com>
On Friday 03 June 2011 11:54:14 Fabio Estevam wrote:
> On Thu, Jun 2, 2011 at 12:33 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> ...
>
> > +void __init imx1_soc_init(void)
> > +{
> > + mxc_register_gpio(0, MX1_GPIO1_BASE_ADDR, SZ_4K, MX1_GPIO_INT_PORTA, 0);
> > + mxc_register_gpio(1, MX1_GPIO2_BASE_ADDR, SZ_4K, MX1_GPIO_INT_PORTB, 0);
> > + mxc_register_gpio(2, MX1_GPIO3_BASE_ADDR, SZ_4K, MX1_GPIO_INT_PORTC, 0);
> > + mxc_register_gpio(3, MX1_GPIO4_BASE_ADDR, SZ_4K, MX1_GPIO_INT_PORTD, 0);
>
> By just reading the function names like "imx1_soc_init" we have really
> no clue of what it actually does.
>
> "soc_init" is too vague IMHO. Could´t you change the names to
> something like "imx1_gpio_init" or "imx1_gpio_register".
>
> It would be nice at least are dealing with gpio.
Olof and I asked Shawn to do it specifically this way, so we have a place
where more SOC specific initialization can be added without having to
change every single board file.
Arnd
next prev parent reply other threads:[~2011-06-03 13:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 3:33 [PATCH v2 0/4] Move plat-mxc gpio driver into drivers/gpio Shawn Guo
2011-06-02 3:33 ` [PATCH v2 1/4] gpio: gpio-mxc: add gpio driver for Freescale MXC architecture Shawn Guo
2011-06-02 5:24 ` Olof Johansson
2011-06-02 3:33 ` [PATCH v2 2/4] ARM: mxc: migrate mach-mx5 gpio driver to gpio-mxc Shawn Guo
2011-06-02 5:18 ` Olof Johansson
2011-06-02 3:33 ` [PATCH v2 3/4] ARM: mxc: migrate mach-imx " Shawn Guo
2011-06-02 5:19 ` Olof Johansson
2011-06-03 10:59 ` Philippe Rétornaz
2011-06-03 11:54 ` Fabio Estevam
2011-06-03 13:23 ` Arnd Bergmann [this message]
2011-06-02 3:33 ` [PATCH v2 4/4] ARM: mxc: remove plat-mxc/gpio driver Shawn Guo
2011-06-02 5:20 ` Olof Johansson
2011-06-03 7:52 ` [PATCH v2 0/4] Move plat-mxc gpio driver into drivers/gpio Russell King - ARM Linux
2011-06-03 14:34 ` Shawn Guo
2011-06-03 14:55 ` Grant Likely
2011-06-03 15:26 ` Shawn Guo
2011-06-03 15:47 ` Grant Likely
2011-06-03 15:48 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106031323.01024.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=festevam@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox