Re: [PATCH 0/5] tracing, function, graph: Fixies for field display

[Jiri Olsa <jolsa@redhat.com>]

On Fri, Jun 03, 2011 at 10:26:55AM -0400, Steven Rostedt wrote:
> On Fri, 2011-06-03 at 16:19 +0200, Jiri Olsa wrote:
> > hi,
> > 
> > this patchset contains some fixies of trace output for
> > function and function_graph tracers.
> > 
> > attached patches:
> > 1/5 tracing, function_graph: Remove dependency of abstime and duration fields on latency
> > 2/5 tracing, function_graph: Merge overhead and duration display functions
> > 3/5 tracing, function: Fix trace header to follow context-info option
> > 4/5 tracing, function_graph: Remove lock-depth from latency trace
> > 5/5 tracing, function_graph: Add context-info support for function_graph tracer
> 
> Hi Jiri,
> 
> Thanks for these patches. But could you change the change logs to show
> the problems that you see. Just a description does not express what is
> really wrong. Basically add a:
> 
> This is what it looked like before:
> 
> ....
> 
> 
> This is what it looks like now:
> 
> ....
> 
> 
> That way it is obvious what the patches do. I'll test these anyway to
> get a before and after, but it is helpful to see it in the change log.
> 
> Thanks,
> 
> -- Steve
> 
> 

sure, I'll resend v2 shortly

thanks,
jirka