Re: [RFC 2/6] omap: iovmm: generic iommu api migration

Laurent Pinchart
2011-06-08T10:46:58Z

Hi Ohad,

On Tuesday 07 June 2011 15:46:26 Ohad Ben-Cohen wrote:
> On Tue, Jun 7, 2011 at 2:26 PM, Laurent Pinchart wrote:
> >> Right now we have a BUG_ON if pa is unaligned, but that can be changed
> >> if needed (do we want it to handle offsets ?).
> >
> > At least for the OMAP3 ISP we need to, as video buffers don't necessarily
> > start on page boundaries.
>
> Where do you take care of those potential offsets today ? Or do you
> simply ignore the offsets and map the entire page ?

Here http://marc.info/?l=linux-omap&m=130693502326513&w=2 :-)

> Seems like omap's iommu (mostly) rejects unaligned pa addresses, see:
>
> 4abb761749abfb4ec403e4054f9dae2ee604e54f "omap iommu: Reject unaligned
> addresses at setting page table entry"
>
> (this doesn't seem to cover 4KB entries though, only large pages,
> sections and super sections)
>
> > A separate patch is indeed needed, yes. As you're already working on
> > iommu it might be simpler if you add it to your tree.
>
> Sure, i'll send it.

--
Regards,

Laurent Pinchart