From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@elte.hu
Subject: Re: [PATCH] perf: make annotate more readable
Date: Fri, 3 Jun 2011 15:59:11 -0300 [thread overview]
Message-ID: <20110603185911.GB23336@ghostprotocols.net> (raw)
In-Reply-To: <20110603185633.GA23336@ghostprotocols.net>
Em Fri, Jun 03, 2011 at 03:56:33PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, May 17, 2011 at 05:32:07PM +0200, Stephane Eranian escreveu:
> >
> > This patch adds two new options to perf annotate:
> > - -R, --no-asm-raw : do not display raw instruction encodings
> > - -S, --no-source : do not interleave source code with assembly code
> >
> > We believe those options make the output of annotate more readable.
> > Systematically displaying source can make it hard to follow code and
> > especially optimized code.
> >
> > Raw encodings are not useful in most cases.
>
> Ok, applying it and then adding a followup patch to have these new
> options in both 'perf top' and 'perf report', since you can do
> annotation (live and static, respectively) from those tools.
Will change it to --source and --asm-raw, since we have logic to negate
any option by adding "no-" after '--' and before boolean options.
- Arnaldo
next prev parent reply other threads:[~2011-06-03 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 15:32 [PATCH] perf: make annotate more readable Stephane Eranian
2011-05-17 15:46 ` Peter Zijlstra
2011-06-03 18:56 ` Arnaldo Carvalho de Melo
2011-06-03 18:59 ` Arnaldo Carvalho de Melo [this message]
2011-06-03 19:04 ` Måns Rullgård
2011-08-18 20:13 ` [tip:perf/core] perf annotate: Make output " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110603185911.GB23336@ghostprotocols.net \
--to=acme@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox