linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	WANG Cong <xiyou.wangcong@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, Jeff Dike <jdike@addtoit.com>,
	Andi Kleen <andi@firstfloor.org>,
	Huang Ying <ying.huang@intel.com>, Li Wei <W.Li@Sun.COM>,
	Michael Ellerman <michaele@au1.ibm.com>,
	Ingo Molnar <mingo@elte.hu>,
	Heiko Carstens <heicars2@linux.vnet.ibm.com>,
	Martin Schwidefsky <mschwid2@linux.vnet.ibm.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] Disable CONFIG_CONSTRUCTORS when not needed by CONFIG_GCOV_KERNEL
Date: Sun, 5 Jun 2011 01:21:02 -0700	[thread overview]
Message-ID: <20110605082100.GA18151@leaf> (raw)

CONFIG_CONSTRUCTORS controls support for running constructor functions
at kernel init time.  According to commit
b99b87f70c7785ab1e253c6220f4b0b57ce3a7f7, gcov (CONFIG_GCOV_KERNEL)
needs this.  However, CONFIG_CONSTRUCTORS currently defaults to y, with
no option to disable it, and CONFIG_GCOV_KERNEL depends on it.  Instead,
default it to n and have CONFIG_GCOV_KERNEL select it, so that the
normal case of CONFIG_GCOV_KERNEL=n will result in
CONFIG_CONSTRUCTORS=n.

Observed in the short list of =y values in a minimal kernel
configuration.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
CCing people copied on the original commit
b99b87f70c7785ab1e253c6220f4b0b57ce3a7f7.

 init/Kconfig        |    1 -
 kernel/gcov/Kconfig |    3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index ebafac4..e9bf65f 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -19,7 +19,6 @@ config DEFCONFIG_LIST
 config CONSTRUCTORS
 	bool
 	depends on !UML
-	default y
 
 config HAVE_IRQ_WORK
 	bool
diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
index b8cadf7..5bf924d 100644
--- a/kernel/gcov/Kconfig
+++ b/kernel/gcov/Kconfig
@@ -2,7 +2,8 @@ menu "GCOV-based kernel profiling"
 
 config GCOV_KERNEL
 	bool "Enable gcov-based kernel profiling"
-	depends on DEBUG_FS && CONSTRUCTORS
+	depends on DEBUG_FS
+	select CONSTRUCTORS
 	default n
 	---help---
 	This option enables gcov-based code profiling (e.g. for code coverage
-- 
1.7.5.3


             reply	other threads:[~2011-06-05  8:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-05  8:21 Josh Triplett [this message]
2011-06-06 10:56 ` [PATCH] Disable CONFIG_CONSTRUCTORS when not needed by CONFIG_GCOV_KERNEL Peter Oberparleiter
2011-06-06 22:11   ` Josh Triplett
2011-06-07  2:39     ` Américo Wang
2011-06-06 15:52 ` Américo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110605082100.GA18151@leaf \
    --to=josh@joshtriplett.org \
    --cc=W.Li@Sun.COM \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=heicars2@linux.vnet.ibm.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michaele@au1.ibm.com \
    --cc=mingo@elte.hu \
    --cc=mschwid2@linux.vnet.ibm.com \
    --cc=oberpar@linux.vnet.ibm.com \
    --cc=rusty@rustcorp.com.au \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xiyou.wangcong@gmail.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).