Re: [PATCH 1/1] boot: Enhance performance by eliminating unnecessary calls to printf()

Valdis.Kletnieks
2011-06-14T18:23:46Z

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

On Sun, 12 Jun 2011 12:36:28 MDT, Jean Sacren said:

> Subject: [PATCH 1/1] boot: Enhance performance by eliminating unnecessary calls to printf()
>
> Repeated calling to printf() for 13 times is a dire waste of CPU cycles.
> For performance, combine all those calls into one while source code
> formatting is preserved for readability.

*facepalm*

I defy anybody to find a *less* performance-critical piece of code to
micro-optimize. It doesn't even make a boot faster, it makes a kernel build
non-measurably faster.

If you wanted to make kernel builds faster, go look at Ingo's numbers regarding
the current #include mess - fixing *that* will be of more benefit than this...

[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]