From: Ingo Molnar <mingo@elte.hu>
To: Andy Lutomirski <luto@MIT.EDU>
Cc: x86@kernel.org, pageexec@freemail.hu,
Mikael Pettersson <mikpe@it.uu.se>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/3] x86-64: Clean up vsyscall emulation and remove fixed-address ret
Date: Mon, 6 Jun 2011 19:41:29 +0200 [thread overview]
Message-ID: <20110606174129.GA6412@elte.hu> (raw)
In-Reply-To: <bd468a0e02befab146667fab5de57df7332d54d9.1307380481.git.luto@mit.edu>
* Andy Lutomirski <luto@MIT.EDU> wrote:
> Remove the fixed-address ret in the vsyscall emulation stubs. As a
> result, int 0xcc no longer works if executed from user address space
> (which is OK -- nothing sensible should do that).
>
> Removing support for int 0xcc in user address space cleans up the
> code considerably.
>
> Signed-off-by: Andy Lutomirski <luto@mit.edu>
> ---
> arch/x86/include/asm/vsyscall.h | 10 ++++-
> arch/x86/kernel/vsyscall_64.c | 78 +++++++++++--------------------------
> arch/x86/kernel/vsyscall_emu_64.S | 17 +--------
> 3 files changed, 32 insertions(+), 73 deletions(-)
Ok, this makes the whole series a lot more palatable!
Can i propagate the rename suggested by hpa into patch #3:
CONFIG_COMPAT_VSYSCALL => CONFIG_LEGACY_VSYSCALL
? 'legacy' is probably the best name for this and it thus won't be
confused with the 32-bit compat facilities we have.
Thanks,
Ingo
next prev parent reply other threads:[~2011-06-06 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 17:27 [PATCH 0/3] x86-64: vsyscall emulation cleanups Andy Lutomirski
2011-06-06 17:27 ` [PATCH 1/3] x86-64: Fix outdated comments in vsyscall_64.c Andy Lutomirski
2011-06-06 21:40 ` [tip:x86/vdso] " tip-bot for Andy Lutomirski
2011-06-06 17:27 ` [PATCH 2/3] x86-64: Clean up vsyscall emulation and remove fixed-address ret Andy Lutomirski
2011-06-06 17:41 ` Ingo Molnar [this message]
2011-06-06 17:45 ` Andrew Lutomirski
2011-06-06 17:50 ` Ingo Molnar
2011-06-06 21:40 ` [tip:x86/vdso] " tip-bot for Andy Lutomirski
2011-06-06 17:27 ` [PATCH 3/3] x86-64: Clarify CONFIG_COMPAT_VSYSCALLS text Andy Lutomirski
2011-06-06 21:41 ` [tip:x86/vdso] x86-64: Rename COMPAT_VSYSCALLS to LEGACY_VTIME and clarify documentation tip-bot for Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606174129.GA6412@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@MIT.EDU \
--cc=mikpe@it.uu.se \
--cc=pageexec@freemail.hu \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox