From: Al Viro <viro@ZenIV.linux.org.uk>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] seq_file.h: introduce DECLARE_SEQ_FOPS_{RO,RW}
Date: Mon, 6 Jun 2011 22:22:09 +0100 [thread overview]
Message-ID: <20110606212209.GM11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F3820B7C57@AUSP01VMBX24.collaborationhost.net>
On Mon, Jun 06, 2011 at 04:19:15PM -0500, H Hartley Sweeten wrote:
> On Monday, June 06, 2011 2:08 PM, Al Viro wrote:
> > On Mon, Jun 06, 2011 at 01:19:45PM -0700, H Hartley Sweeten wrote:
> >> Many of the procfs and debugfs attribute file_operations in the kernel are
> >> missing the .owner information. Introduce some macro's to fill in the .owner
> >> field as well as the common methods for virtual file file_operations. This
> >> simplifies creating the attributes and makes sure all the fields are properly
> >> initialized.
> >>
> >> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> >
> > Nacked-by: Al Viro <viro@zeniv.linux.org.uk>
> > Nacked-because: too ugly
> >
> > Don't play that kind of games with preprocessor.
>
> Just an FYI, the exact same thing is being done with DEFINE_SIMPLE_ATTRIBUTE
> in fs.h:
Yes, and DEFINE_SIMPLE_ATTRIBUTE is sick and ugly.
next prev parent reply other threads:[~2011-06-06 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 20:19 [PATCH] seq_file.h: introduce DECLARE_SEQ_FOPS_{RO,RW} H Hartley Sweeten
2011-06-06 21:07 ` Al Viro
2011-06-06 21:18 ` Alexey Dobriyan
2011-06-06 21:19 ` H Hartley Sweeten
2011-06-06 21:22 ` Al Viro [this message]
2011-06-06 21:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606212209.GM11521@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox