linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Jander <david.jander@protonic.nl>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Why does handle_simple_irq() require IRQ's to be disabled?
Date: Tue, 7 Jun 2011 10:55:08 +0200	[thread overview]
Message-ID: <20110607105508.1f3033fa@archvile> (raw)
In-Reply-To: <alpine.LFD.2.02.1106071016490.11814@ionos>


Dear Thomas,

On Tue, 7 Jun 2011 10:26:26 +0200 (CEST)
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Tue, 7 Jun 2011, David Jander wrote:
> > On Mon, 6 Jun 2011 18:18:41 +0200 (CEST)
> > Thomas Gleixner <tglx@linutronix.de> wrote:
> > > handle_nested_irq() is your friend.
> > 
> > Thanks! This worked without disabling IRQ's.
> > One last question, though:
> > 
> > I set up the handler using irq_set_chip_and_handler(irq, ...,
> > handle_simple_irq);
> > From the interrupt thread, I call handle_nested_irq(). Is it OK, that in
> > this case, the defined handler function (handle_simple_irq) is not used?
> > Does this still make sense? Wouldn't calling just irq_set_chip() be enough
> > here (it seems to work correctly)?
> 
> It should be enough. Though you should mark the demuxed interrupts
> with irq_set_nested_thread(irqnr, true). That avoids that you create
> extra threads for the demuxed interrupts which are never used.

Cool! Now the disturbingly big list of kernel threads is gone :-)

Thanks a lot!

-- 
David Jander
Protonic Holland.

      reply	other threads:[~2011-06-07  8:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 15:28 Why does handle_simple_irq() require IRQ's to be disabled? David Jander
2011-06-06 16:18 ` Thomas Gleixner
2011-06-07  7:05   ` David Jander
2011-06-07  8:26     ` Thomas Gleixner
2011-06-07  8:55       ` David Jander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110607105508.1f3033fa@archvile \
    --to=david.jander@protonic.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).