Re: [PATCH v4 3.0-rc2-tip 2/22] 2: uprobes: Breakground page replacement.

Peter Zijlstra
2011-06-09T23:00:20Z

On Tue, 2011-06-07 at 18:28 +0530, Srikar Dronamraju wrote:
> +/**
> + * __replace_page - replace page in vma by new page.
> + * based on replace_page in mm/ksm.c
> + *
> + * @vma: vma that holds the pte pointing to page
> + * @page: the cowed page we are replacing by kpage
> + * @kpage: the modified page we replace page by
> + *
> + * Returns 0 on success, -EFAULT on failure.
> + */
> +static int __replace_page(struct vm_area_struct *vma, struct page *page,
> + struct page *kpage)

This is a verbatim copy of mm/ksm.c:replace_page(), I think I can
remember why you did this, but the changelog utterly fails to mention
why we need a second copy of this logic (or anything much at all).