Re: [PATCH v4 3.0-rc2-tip 7/22] 7: uprobes: mmap and fork hooks.

Srikar Dronamraju
2011-06-09T05:57:23Z

> > +static void add_to_temp_list(struct vm_area_struct *vma, struct inode *inode,
> > + struct list_head *tmp_list)
> > +{
> > + struct uprobe *uprobe;
> > + struct rb_node *n;
> > + unsigned long flags;
> > +
> > + n = uprobes_tree.rb_node;
> > + spin_lock_irqsave(&uprobes_treelock, flags);
> > + uprobe = __find_uprobe(inode, 0, &n);
>
> It is valid for a uprobe offset to be zero I guess, so perhaps we need
> to do a put_uprobe() here when the result of __find_uprobe() is
> non-null.

Right, will check for the result of __find_uprobe and do a put_uprobe().
Will correct this in the next patchset.

--
Thanks and Regards
Srikar