From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757863Ab1FGSiR (ORCPT ); Tue, 7 Jun 2011 14:38:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62057 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762Ab1FGSiQ (ORCPT ); Tue, 7 Jun 2011 14:38:16 -0400 Date: Tue, 7 Jun 2011 20:35:42 +0200 From: Oleg Nesterov To: Jiri Slaby Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, jirislaby@gmail.com, Alan Cox , Al Viro , Andi Kleen , Xiaotian Feng , Neil Horman Subject: [PATCH] do_coredump: fix the "ispipe" error check Message-ID: <20110607183542.GA5559@redhat.com> References: <1307457010-7241-1-git-send-email-jslaby@suse.cz> <20110607181607.GA3732@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110607181607.GA3732@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org do_coredump() assumes that if format_corename() fails it should return -ENOMEM. This is not true, for example cn_print_exe_file() can propagate the error from d_path. Even if it was true, this is too fragile. Change the code to check "ispipe < 0". Signed-off-by: Oleg Nesterov --- fs/exec.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- ptrace/fs/exec.c~corename_errcode 2011-06-07 19:44:30.000000000 +0200 +++ ptrace/fs/exec.c 2011-06-07 20:20:48.000000000 +0200 @@ -2092,16 +2092,16 @@ void do_coredump(long signr, int exit_co ispipe = format_corename(&cn, signr); - if (ispipe == -ENOMEM) { - printk(KERN_WARNING "format_corename failed\n"); - printk(KERN_WARNING "Aborting core\n"); - goto fail_corename; - } - if (ispipe) { int dump_count; char **helper_argv; + if (ispipe < 0) { + printk(KERN_WARNING "format_corename failed\n"); + printk(KERN_WARNING "Aborting core\n"); + goto fail_corename; + } + if (cprm.limit == 1) { /* * Normally core limits are irrelevant to pipes, since