From: Greg KH <gregkh@suse.de>
To: KY Srinivasan <kys@microsoft.com>
Cc: Greg KH <greg@kroah.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"virtualization@lists.osdl.org" <virtualization@lists.osdl.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
"Abhishek Kane (Mindtree Consulting PVT LTD)"
<v-abkane@microsoft.com>
Subject: Re: [PATCH 49/49] Staging: hv: vmbus: Increase the timeout value in vmbus_request_offers()
Date: Tue, 7 Jun 2011 14:28:00 -0700 [thread overview]
Message-ID: <20110607212800.GA3331@suse.de> (raw)
In-Reply-To: <6E21E5352C11B742B20C142EB499E0480813DC6F@TK5EX14MBXC122.redmond.corp.microsoft.com>
On Tue, Jun 07, 2011 at 09:20:16PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Greg KH [mailto:greg@kroah.com]
> > Sent: Tuesday, June 07, 2011 4:45 PM
> > To: KY Srinivasan
> > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> > devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang;
> > Abhishek Kane (Mindtree Consulting PVT LTD)
> > Subject: Re: [PATCH 49/49] Staging: hv: vmbus: Increase the timeout value in
> > vmbus_request_offers()
> >
> > On Mon, Jun 06, 2011 at 03:50:13PM -0700, K. Y. Srinivasan wrote:
> > > Increase the timeout value in vmbus_request_offers().
> >
> > Why? What does this solve/fix/prevent?
>
> On some very loaded systems, when we tested the 1 second timeout that
> we had prior to this patch was insufficient. So I bumped it to 5 seconds.
Ok, then this should be something that goes into 3.0 and older kernels,
right?
If so, please say so, with this type of description, when you submit it.
Remember, don't say only what you did in the changelog comment, but why
you did it if it's not obvious (and it wasn't here.)
Care to resend this one with this information?
thanks,
greg k-h
next prev parent reply other threads:[~2011-06-07 21:28 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 22:49 [PATCH 00/49] Staging: hv: Driver cleanup K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 01/49] Staging: hv: vmbus: In vmbus_child_driver_unregister() don't set the bus field to NULL K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 02/49] Staging: hv: storvsc: Cleanup the exit function in storvsc_drv.c K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 03/49] Staging: hv: storvsc: Cleanup the module init " K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 04/49] Staging: hv: storvsc: Fix a bug in the storvsc_remove() function K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 05/49] Staging: hv: storvsc: Cleanup some dated/unnecessary comments K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 06/49] Staging: hv: stor: Get rid of unnecessary DPRINTs in stor vsc_drv.c K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 07/49] Staging: hv: stor: Rename the vriable gStorVscDeviceType in storvsc_drv.c K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 08/49] Staging: hv: stor: Get rid of the unused initialization of the name field K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 09/49] Staging: hv: blk: " K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 10/49] Staging: hv: mouse: " K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 11/49] Staging: hv: vmbus: Don't free the channel when the channel is closed K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to support auto-loading K. Y. Srinivasan
2011-06-06 23:12 ` Christoph Hellwig
2011-06-07 14:54 ` KY Srinivasan
2011-06-07 18:58 ` Greg KH
2011-06-07 22:19 ` KY Srinivasan
2011-06-07 22:24 ` Greg KH
2011-06-08 2:44 ` KY Srinivasan
2011-06-08 16:22 ` Greg KH
2011-06-06 22:49 ` [PATCH 13/49] Staging: hv: vmbus: Change the signature of vmbus_bus_init() K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 14/49] Staging: hv: vmbus: Use the DSDT specified irq for vmbus K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 15/49] Staging: hv: vmbus: Make vmbus an acpi bus driver K. Y. Srinivasan
2011-06-07 20:44 ` Greg KH
2011-06-06 22:49 ` [PATCH 16/49] Staging: hv: vmbus: Get rid of vmbus_acpi_init() by inlining the code K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 17/49] Staging: hv: vmbus: Get rid of vmbus_acpi_exit() " K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 18/49] Staging: hv: vmbus: Add the DSDT _HID name as well K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 19/49] Staging: hv: blkvsc: Fix bugs in the module unload path K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 20/49] Staging: hv: blkvsc: We don't support removable media; get rid of unnecessary state K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 21/49] Staging: hv: vmbus: Get rid of the timer based handling of channel events K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 22/49] Staging: hv: vmbus: Get rid of the call to dump channel state in channel event handler K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 23/49] Staging: hv: vmbus: Directly invoke the channel callback K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 24/49] Staging: hv: vmbus: Get rid of the unused wrapper - vmbus_onchannel_event() K. Y. Srinivasan
2011-06-06 23:15 ` Christoph Hellwig
2011-06-07 14:59 ` KY Srinivasan
2011-06-07 18:58 ` Greg KH
2011-06-07 19:58 ` KY Srinivasan
2011-06-07 20:09 ` Greg KH
2011-06-06 22:49 ` [PATCH 25/49] Staging: hv: vmbus: Get rid of unneeded calls to dump_vmbus_channel K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 26/49] Staging: hv: vmbus: Get rid of the poll timer in the channel state K. Y. Srinivasan
2011-06-06 23:15 ` Christoph Hellwig
2011-06-06 22:49 ` [PATCH 27/49] Staging: hv: vmbus: Fix the memory barrier in hv_ringbuffer_read() K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 28/49] Staging: hv: vmbus: Introduce read dependency in hv_get_ringbuffer_availbytes() K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 29/49] Staging: hv: vmbus: Change the memory barrier in hv_ringbuffer_write() K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 30/49] Staging: hv: vmbus: Get rid of the unused function vmbus_ontimer() K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 31/49] Staging: hv: vmbus: Get rid of some dated comments in channel.c K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 32/49] Staging: hv: vmbus: Correct " K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 33/49] Staging: hv: vmbus: Move the definition of struct vmbus_channel K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 34/49] Staging: hv: vmbus: Embed the state needed to close the channel K. Y. Srinivasan
2011-06-06 22:49 ` [PATCH 35/49] Staging: hv: vmbus: Use the newly introduced state in closing " K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 36/49] Staging: hv: vmbus: Get rid of a dated comment in vmbus_drv.c K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 37/49] Staging: hv: vmbus: Get rid of an unused function in connection.c K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 38/49] Staging: hv: vmbus: Get rid of a dated comment in channel_mgmt.c K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 39/49] Staging: hv: vmbus: Fix a memory barrier call in vmbus_drv.c K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 40/49] Staging: hv: vmbus: Rename local variables " K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 41/49] Staging: hv: vmbus: Increase the timeout for some critical calls K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 42/49] Staging: hv: vmbus: Properly handle memory allocation failure in channel.c K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 43/49] Staging: hv: vmbus: Cleanup some error codes in vmbus_drv.c K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 44/49] Staging: hv: vmbus: Cleanup error handling in vmbus_bus_init() K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 45/49] Staging: hv: vmbus: Cleanup error codes in hv.c K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 46/49] Staging: hv: vmbus: Cleanup error codes in connection.c K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 47/49] Staging: hv: vmbus: Cleanup some error values in channel.c K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 48/49] Staging: hv: vmbus: Change Cleanup to cleanup " K. Y. Srinivasan
2011-06-06 22:50 ` [PATCH 49/49] Staging: hv: vmbus: Increase the timeout value in vmbus_request_offers() K. Y. Srinivasan
2011-06-07 20:45 ` Greg KH
2011-06-07 21:20 ` KY Srinivasan
2011-06-07 21:28 ` Greg KH [this message]
2011-06-07 21:39 ` KY Srinivasan
2011-06-07 20:48 ` [PATCH 00/49] Staging: hv: Driver cleanup Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607212800.GA3331@suse.de \
--to=gregkh@suse.de \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=v-abkane@microsoft.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).