From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/5] Fix mismatched variable in rcutree_trace.c
Date: Tue, 7 Jun 2011 17:13:13 -0700 [thread overview]
Message-ID: <20110608001313.GI2286@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110607234356.GA27166@one.firstfloor.org>
On Wed, Jun 08, 2011 at 01:43:56AM +0200, Andi Kleen wrote:
> > Hmmm... Some arches have signed CPU numbers while others have unsigned
> > CPU numbers. I do use "-1" to mean "no CPU" in some cases (for example,
> > in rcu_node_kthread_setaffinity()), so I guess for consistency I should
> > be using "int" everywhere.
>
> Do I hear that "int" is ok for you? If yes I will not revise the patch
> and please merge it. If it needs changes please let me know.
Yep, "int" is OK. I queued your patch and am testing it now.
Thank you for catching this!
Thanx, Paul
next prev parent reply other threads:[~2011-06-08 0:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 22:26 [PATCH 1/5] SH: drop const from io port variiable Andi Kleen
2011-06-07 22:26 ` [PATCH 2/5] Fix mismatched variable in rcutree_trace.c Andi Kleen
2011-06-07 22:42 ` Thomas Gleixner
2011-06-07 23:13 ` Paul E. McKenney
2011-06-07 23:43 ` Andi Kleen
2011-06-08 0:13 ` Paul E. McKenney [this message]
2011-06-07 22:26 ` [PATCH 3/5] IRDA: Fix global type conflicts in net/irda/irsysctl.c Andi Kleen
2011-06-09 7:29 ` David Miller
2011-06-07 22:26 ` [PATCH 4/5] ixgbe: Fix incorrect declaration of ixgbevf_mbx_ops Andi Kleen
2011-06-07 22:56 ` Rose, Gregory V
2011-06-08 19:04 ` Jeff Kirsher
2011-06-07 22:26 ` [PATCH 5/5] Avoid section type conflict in dma/ioat/dma_v3.c Andi Kleen
2011-06-07 23:07 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608001313.GI2286@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox