From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
x86@kernel.org
Subject: Re: [PATCH] x86: Fix sys_call_table type in asm/syscall.h
Date: Wed, 8 Jun 2011 10:03:46 +0200 [thread overview]
Message-ID: <20110608080346.GA11110@elte.hu> (raw)
In-Reply-To: <1307490307-27443-1-git-send-email-andi@firstfloor.org>
* Andi Kleen <andi@firstfloor.org> wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Make the sys_call_table type defined in asm/syscall.h match
> the definition in syscall_64.c
>
> Cc: x86@kernel.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> arch/x86/include/asm/syscall.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h
> index c4a348f..32295b7 100644
> --- a/arch/x86/include/asm/syscall.h
> +++ b/arch/x86/include/asm/syscall.h
> @@ -16,7 +16,8 @@
> #include <linux/sched.h>
> #include <linux/err.h>
>
> -extern const unsigned long sys_call_table[];
> +typedef void (*sys_call_ptr_t)(void);
> +extern const sys_call_ptr_t sys_call_table[];
>
> /*
> * Only the low 32 bits of orig_ax are meaningful, so we return int.
There's an obvious problem with this patch, please fix it and resend.
Thanks,
Ingo
next prev parent reply other threads:[~2011-06-08 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 23:45 [PATCH] x86: Fix sys_call_table type in asm/syscall.h Andi Kleen
2011-06-08 8:03 ` Ingo Molnar [this message]
2011-06-08 8:17 ` Andi Kleen
2011-06-08 8:25 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608080346.GA11110@elte.hu \
--to=mingo@elte.hu \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox